Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3604203pxf; Mon, 15 Mar 2021 13:35:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzo2SYQhrjMHy5G4kBhrW0QV27LI+Xd94PvHSCGhqHdqN7ZZdc9gxBh/ZNYDL0rz7BGHlRA X-Received: by 2002:a17:907:10ce:: with SMTP id rv14mr26141412ejb.56.1615840524948; Mon, 15 Mar 2021 13:35:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615840524; cv=none; d=google.com; s=arc-20160816; b=HmVMehXFntm+CrjtwZXLLwqsQcrdhNF0gcTtUxuYDKCW2MrQfLp/ovQiDH2mngOjYM Dv1taO9Q/hXjJQToOW/hx9xWeRtURi6QtoW045HBC0k5fT/w+BS71wzY6r7e+OXDFtc0 XY2cwD3AjOHbKbKp+vgM0xvGN1+5J+0F2c3EhPcCauJwOruV2EI1agSWvD0PqnnALTtT pexdmgSfoVh9jBdEiiBWyrcboMfD/oRzZ4rShlOTMIQsnlNIrPlH+Ft5Ta1EobkmfBFD NvZKOvnxcR539fswJ5+hclaBNUYKk6mmDWxm79oYdVTYWMIgpHJJu+nfMnzqAvBAu6no IrEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7dHd3VnSNg5KZMgkWTLAFsTuSg1qebri+zbtU6jQyuU=; b=vDmpWS+bzfZkGEbWKo/yDY/j5w+DHsAdxDNWeHNFJMC0RuJcKm0TPaM8wZHinyQg8G NsTPYBBaJIj2Vj8aCHyf1b0UDDBFK5Q/HEoqr5GRv1ZUoLlsJawgG3pxzy8Si92R9ANc RnC7oaH8OR++8z14sh3JPSz5PzsQSNDR5VvhTmp8AxR0QdotigRddLIUVje027NucX2u TITW4XuVEM4+ajgIGMui7mEd66VuzxKY3NDjsnEi7d+cGZujfdLbSLeA+ZXB+UNRLP4p u6XSglgacGbpFt30tJEs7KeTleAidAbKQrwPq1djIxZAqqNpifXblfLRI5pt7oTIlIpm WEgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UPyDWkaX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si11328692ejw.650.2021.03.15.13.34.56; Mon, 15 Mar 2021 13:35:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UPyDWkaX; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232299AbhCOSVN (ORCPT + 99 others); Mon, 15 Mar 2021 14:21:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57969 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232079AbhCOSVE (ORCPT ); Mon, 15 Mar 2021 14:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615832464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7dHd3VnSNg5KZMgkWTLAFsTuSg1qebri+zbtU6jQyuU=; b=UPyDWkaXyWSHajQrY5/r6UzvqKruO0jBDALURt0m6moaCIsAw+uLnEM/e43R786HElcklT LBgLyH9Hp45BLGW95o3leWn27I4BijqWN7jAO23wp9p91Pa1c/qsbx+qImq9rS/PSlr/Er n+FG2pgGDZgd96TQKyC7vl1hjEnTfoE= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-CU9G4SouPrKyb2_t79ewFw-1; Mon, 15 Mar 2021 14:21:02 -0400 X-MC-Unique: CU9G4SouPrKyb2_t79ewFw-1 Received: by mail-oo1-f72.google.com with SMTP id l19so16384602oov.19 for ; Mon, 15 Mar 2021 11:21:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7dHd3VnSNg5KZMgkWTLAFsTuSg1qebri+zbtU6jQyuU=; b=e6pU2yNDlg2jDLWHM/zDdTMB0DndcE+dCtgBuhjufh0atAy0PDR7wVilJzQLfIj9xC 1+RAcIt3FyiXYLUfFHEHD+1XXbUepUfHLOSldInZgA5iBBP7te1L1xLQvGquq6OwkmnX VaC9LluI9NN53vVrHjDyExsGDsSpFdkGTYAWDyX4PeBGfR7sARJ0Uo2vMtLZOALxzefI qhEEsMzCUFcTW3E5AimqX2nxhBZCND4ukJV2aq7nvsia6l/j+e3uHNPq4bthu2HnlCzb on3IEt/2P0siPqQV+BKLxyFsjMdavX9D3AcJgB1YBNI3LtvzlSVqNFZdYShoTnIIl6kl 0vSA== X-Gm-Message-State: AOAM533wEU7npsohyV2XFDMDKMLKlNIwGP1s20ZzQqplEYKazPl8YNHj ZH6n4D+elEm7oLqLIy+oWs69FiAIXq29wWCfZKd0ZB42z6GceYXhHzYTMSghB2HAvheZDF6/hhs 6Wcm7A7p4AThvP6OQk5dkhWvt+5pgb46/59YGq8fzO84= X-Received: by 2002:a9d:73d0:: with SMTP id m16mr362909otk.172.1615832461723; Mon, 15 Mar 2021 11:21:01 -0700 (PDT) X-Received: by 2002:a9d:73d0:: with SMTP id m16mr362889otk.172.1615832461458; Mon, 15 Mar 2021 11:21:01 -0700 (PDT) MIME-Version: 1.0 References: <20210312163651.1398207-1-jarod@redhat.com> <87lfasaxug.fsf@tynnyri.adurom.net> In-Reply-To: <87lfasaxug.fsf@tynnyri.adurom.net> From: Jarod Wilson Date: Mon, 15 Mar 2021 14:20:49 -0400 Message-ID: Subject: Re: [PATCH net] wireless/nl80211: fix wdev_id may be used uninitialized To: Kalle Valo Cc: LKML , Johannes Berg , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, Netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Mar 12, 2021 at 4:04 PM Kalle Valo wrote: > > Jarod Wilson writes: > > > Build currently fails with -Werror=maybe-uninitialized set: > > > > net/wireless/nl80211.c: In function '__cfg80211_wdev_from_attrs': > > net/wireless/nl80211.c:124:44: error: 'wdev_id' may be used > > uninitialized in this function [-Werror=maybe-uninitialized] > > Really, build fails? Is -Werror enabled by default now? I hope not. Don't think so. But we (Red Hat) build all our kernels with a fair amount of extra error-checking enabled. -- Jarod Wilson jarod@redhat.com