Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Cedric VONCKEN <cedric.voncken@acksys.fr>
To:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: WMM doesn't work for VLAN frame
Thread-Topic: WMM doesn't work for VLAN frame
Thread-Index: AdcadHCybNZXp2khSi6M+ePRwqq6bw==
Date:   Tue, 16 Mar 2021 15:15:48 +0000
Message-ID: <PR3PR01MB67144B33C65712847FFB558D906B9@PR3PR01MB6714.eurprd01.prod.exchangelabs.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fc3cf4bc-dcf5-49bb-866f-08d8e88e6136
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2021 15:15:48.5634
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f18a6414-d5f3-4b5c-9345-f30c01d87e32
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iFPYNlQnt5PcU9cCZWd+nX5MZhgtX+6n+/hazkTCoFjiEfTCyCc1cwHRDbLzasM4fXdVkAhvuhl5nD0C+SfUq4JWkNLQLuHQDUXtchw6lcM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR01MB6796
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

	Hi all,

	I have an issue with vlan frames and WMM management.
	I use an AP and a STA. The AP have a basic setings (wifi is bridged with l=
an interface).
	On the sta, I add a 802.1q device on wlan interface (vconfig add wlan0 7) =
and this interface is routed with the LAN. The settings works correctly I c=
an ping the computer connected to the AP from a computer connect to the sta=
.

	On the computer connected to the sta I launch iperf with the parameter -S0=
xc0, with wireshark I checked the frame on the air, and the WMM priority is=
 set to Best effort.
	I added some printk in my kernel, and the call order is
	[   64.134443] __dev_queue_xmit called
	[   64.137935] validate_xmit_vlan called
	[   64.144290] ieee80211_subif_start_xmit: called=20
	[   64.151343] cfg80211_classify8021d: called=20

	Explantation of the issue
		1. The validate_xmit_vlan function add the the vlan tag in the skb frame,=
 set skb->protocol to VLAN protocol (0x8100) and set skb->vlan_tci to 0.
		2. The cfg80211_classify8021d use these fields to determine the frame pri=
ority, but the skb->protocol value (0x8100) is not handled byt this functio=
n and this function return a default value 0.

	I found this issue with the backport 5.4-rc8-1 from openwrt and the kernel=
 4.9

	With an older backport (2017-11-01) and the same kernel version the call o=
rder is differant
		[  536.195431] __dev_queue_xmit called
		[  536.198922] cfg80211_classify8021d called
		[  536.205799] validate_xmit_vlan called

	With this order the cfg80211_classify8021d work correctly and my traffic u=
se the correct WMM class.

	Do you have any idea to fix this issue?
Regards

Cedric Voncken