Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <05ede675a6829ab3f3e69a1766a9df39f18ad024.camel@sipsolutions.net>
Subject: Re: [PATCH v2] cfg80211: avoid holding the RTNL when calling the
 driver
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Peter Collingbourne <pcc@google.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Thu, 18 Mar 2021 20:13:08 +0100
In-Reply-To: <CAMn1gO6PoOZyejd_Pu0fj9DHz7d8ty8-sb8voRvXd3=-XV23jA@mail.gmail.com> (sfid-20210318_201103_082515_6B31AB13)
References: <CAMn1gO7evHe+pvcFwv1XE+y090CSWwXL=pRKjZwmnrZa3j4gtg@mail.gmail.com>
         <a4502cc2a3547780b075e4ee0d3946f9b727adb9.camel@sipsolutions.net>
         <CAMn1gO6PoOZyejd_Pu0fj9DHz7d8ty8-sb8voRvXd3=-XV23jA@mail.gmail.com>
         (sfid-20210318_201103_082515_6B31AB13)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-03-18 at 12:10 -0700, Peter Collingbourne wrote:

> Yes, it was deadlocking after a few minutes, although at that time I
> hadn't confirmed that the deadlock was being caused by the patch or by
> some other issue.

Ah ok :)

> > In any case, I fixed it here, I believe:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=77cbf790e5b482256662e14c8b6ef4fecb07d06d
> 
> I cherry-picked that patch and tested it on my setup, and it fixed
> both the warnings and the deadlocks. So if you like you can add my:
> 
> Tested-by: Peter Collingbourne <pcc@google.com>

Too late since it's already applied and just got into net also (so
hopefully into rc4), but thanks for confirming that it works!

johannes