Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: pradeepc=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 18 Mar 2021 13:24:44 -0700
From:   Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To:     Karthikeyan periyasamy <periyasa@codeaurora.org>
Cc:     ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
        Miles Hu <milehu@codeaurora.org>,
        John Crispin <john@phrozen.org>,
        pradeepc=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v7 1/3] ath11k: switch to using ieee80211_tx_status_ext()
In-Reply-To: <65a8f70609a1758611c97205abd205f2@codeaurora.org>
References: <20210305230337.23047-1-pradeepc@codeaurora.org>
 <20210305230337.23047-2-pradeepc@codeaurora.org>
 <65a8f70609a1758611c97205abd205f2@codeaurora.org>
Message-ID: <dde25ece7fcbc6a0f268c98aa461d792@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

>> +	spin_lock_bh(&ab->base_lock);
>> +	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
>> +	if (peer) {
>> +		arsta = (struct ath11k_sta *)peer->sta->drv_priv;
>> +		status.sta = peer->sta;
>> +		status.skb = msdu;
>> +		status.info = info;
>> +		status.rate = &arsta->last_txrate;
>> +	}
>> +	rcu_read_unlock();
>> +	if (peer)
>> +		ieee80211_tx_status_ext(ar->hw, &status);
>> +	else
>> +		dev_kfree_skb_any(msdu);
>> +	spin_unlock_bh(&ab->base_lock);
> 
> Why ieee80211_tx_status_ext() kept under spin_lock?
> 
> Thanks,
> Karthikeyan P
Thanks Karthikeyan for the review..Yes, spin lock could be avoided for
ieee80211_tx_status_ext(). I will address this in next revision.

Thanks
pradeep