Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1132618pxf; Thu, 18 Mar 2021 22:44:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+LU46vY4LtaJd2tl2ZZhR2swAYEceWZ6etmCiDjY+g5e5i0D+Y4eSq1BzrVEX+6tX+9KG X-Received: by 2002:a17:907:2d89:: with SMTP id gt9mr2430435ejc.226.1616132675247; Thu, 18 Mar 2021 22:44:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616132675; cv=none; d=google.com; s=arc-20160816; b=fLSZ2Um96grsodTTszBmBpd7dqS1OzfGwosGFAg2JB+WFGHZ2d+JmX/M9NyVOFxoFA bPIf95giQsvXWMfOQxgJHRl9eQ/K8lA0/5u86UOYvHh0R7ygYYpbg4mIkdVCkvLVdoU3 TczXVS0n+LkMY3npxaae2jYUKK8MBdj1FdwtHl2T6y3/lDHA9AXfFG05pwVLqgTluzZU vuXyTzSsYLuX7Bk8ggWqUZpNrleQv4vXyr2wa0J4yA1VRbNBUiEGhOt8dczPrhzxlcNM SyM4H6EiZPKjovsgtR52K/PFm/Bv3ZwEBSjybEsuxr4E7vafKHQsRoKbz3eBUkZwAx0N ZE5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :authenticated-by; bh=oeaUCbL8cgS8C7Y4aXnK3cLfAAEOOF85fS6Uj3VaDkI=; b=1Gr1PH6EGH+KhcF8eL1QhgJq25MZ57QmwGccVn3qZftD5HIMZTq++iLpWV3/2w0F9w mqyfITM7FS3Hb4/s+RK84X7hv9kRqXpPcajFlJA0PA8mTSU1xDoUzytRIUd1CFE5c9Ra KWvYX+jDcrsTH8knDXx0MrHxj612IEPiIioJBzVbirq7ue+tSlmmuwxJm3KaHcKtoJwC KLm+9mOFOgHZ4eNTA0bhkKO0LEK57KTZ1lKd0fGlqY3ingmozk1+w/gLFbluXJVPPSE8 RFH1RwX58An1XNzhC3DRwd1L0g6DxRHMhBoaGvaHWn02a+wUUZPNyTtC/90sW2c2ND2L ssKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p10si3353781edm.261.2021.03.18.22.44.12; Thu, 18 Mar 2021 22:44:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233900AbhCSFnb (ORCPT + 99 others); Fri, 19 Mar 2021 01:43:31 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:39717 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233846AbhCSFnN (ORCPT ); Fri, 19 Mar 2021 01:43:13 -0400 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 12J5h7aN5007706, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexmbs04.realtek.com.tw[172.21.6.97]) by rtits2.realtek.com.tw (8.15.2/2.70/5.88) with ESMTPS id 12J5h7aN5007706 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 19 Mar 2021 13:43:07 +0800 Received: from localhost (172.21.69.146) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 19 Mar 2021 13:43:07 +0800 From: Ping-Ke Shih To: , CC: , , , , , Subject: [PATCH 3/7] rtw88: fix DIG min setting Date: Fri, 19 Mar 2021 13:42:14 +0800 Message-ID: <20210319054218.3319-4-pkshih@realtek.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20210319054218.3319-1-pkshih@realtek.com> References: <20210319054218.3319-1-pkshih@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [172.21.69.146] X-ClientProxiedBy: RTEXMBS01.realtek.com.tw (172.21.6.94) To RTEXMBS04.realtek.com.tw (172.21.6.97) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Zong-Zhe Yang DIG min is expected to be set according to chip. And actually we assigned it under each chip information. However, we didn't use the setting when we did DIG process. It is unexpected, so we fix it. Signed-off-by: Zong-Zhe Yang Signed-off-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/phy.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c index e114ddecac09..f96edc049718 100644 --- a/drivers/net/wireless/realtek/rtw88/phy.c +++ b/drivers/net/wireless/realtek/rtw88/phy.c @@ -316,7 +316,8 @@ rtw_phy_dig_check_damping(struct rtw_dm_info *dm_info) return damping; } -static void rtw_phy_dig_get_boundary(struct rtw_dm_info *dm_info, +static void rtw_phy_dig_get_boundary(struct rtw_dev *rtwdev, + struct rtw_dm_info *dm_info, u8 *upper, u8 *lower, bool linked) { u8 dig_max, dig_min, dig_mid; @@ -325,8 +326,7 @@ static void rtw_phy_dig_get_boundary(struct rtw_dm_info *dm_info, if (linked) { dig_max = DIG_PERF_MAX; dig_mid = DIG_PERF_MID; - /* 22B=0x1c, 22C=0x20 */ - dig_min = 0x1c; + dig_min = rtwdev->chip->dig_min; min_rssi = max_t(u8, dm_info->min_rssi, dig_min); } else { dig_max = DIG_CVRG_MAX; @@ -437,7 +437,8 @@ static void rtw_phy_dig(struct rtw_dev *rtwdev) * the peers connected with us, meanwhile make sure the igi value does * not beyond the hardware limitation */ - rtw_phy_dig_get_boundary(dm_info, &upper_bound, &lower_bound, linked); + rtw_phy_dig_get_boundary(rtwdev, dm_info, &upper_bound, &lower_bound, + linked); cur_igi = clamp_t(u8, cur_igi, lower_bound, upper_bound); /* record current igi value and false alarm statistics for further -- 2.21.0