Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3734386pxf; Mon, 22 Mar 2021 13:43:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOToZS84G5EUs7lmpMyx9LOVpIffW0CJc4b/xoc2EYZtPhpPL0M++Mpin6bw7xcg8UFBeH X-Received: by 2002:a17:907:216d:: with SMTP id rl13mr1575413ejb.362.1616445810514; Mon, 22 Mar 2021 13:43:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616445810; cv=none; d=google.com; s=arc-20160816; b=l5xgZxuagT/07EnBiUJo3WCyR2wLH2tpmpWNlMoV9D415VXBRgS7aJ9Dy0a2gNA8Qf OFkmTWMcViVJuBzZ572KDJOCPVxTyLP35assBtBTpTPVz2bVQUsyuLuWD0POp0vUEkMs FIA4skWJnAyUgn7oXXVs7pjNEFuBOMg3CUGpcDMyITJVAiDdjiWUviKOQTJtb2PNhySO 5OR8S3MsRGKkPAlaOIyN2mvIILriGtOVaXJQiSQr5UiTgYPCxLWbF3XN0+WhNHU87Xw4 CkDbOoHBSkjtguWXsyy7mH2f7BcHuExI5RMqe5q6T2qhQh2kGGqezq8HiKtRTXESfbCD 8wLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=gkXdCaYL0C5oHIFCp3MmSywS3Wwt+9QJH1/+GTclNEw=; b=UKtB/nb4CKGQ4TWmvWy8K0ciXl/aOK0KGhZfrT4ysPSaQYbY2/h5Sgnv4a/0E1MsjE wiYoYMXKscaSOm8TkPJPgO/UTUrc4ekmMjf/ibYUbdlDCUvgqV5wORXkCOn3mzSH/VHc yPFCFag5zlnblgVws5iiVSGZXmBkpbg6uFmxuAoA057Ko0sVGEJopufPOx4xUyL+c4B8 ICZtWivsAPh2Jzm79CzB7TqZk7csUhIdXn1myM0pzU5q/Q8TjmJReqH3q3Gu2/nuZ+0V EkDTS9dAhcafqXAKplTdbrDZrMOZcHpT7pI4VEVi+trN2fo1nchUs9W97yZf+u/wnhFl iJKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si12031548ejb.59.2021.03.22.13.43.06; Mon, 22 Mar 2021 13:43:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231189AbhCVUml (ORCPT + 99 others); Mon, 22 Mar 2021 16:42:41 -0400 Received: from mga12.intel.com ([192.55.52.136]:48250 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbhCVUmN (ORCPT ); Mon, 22 Mar 2021 16:42:13 -0400 IronPort-SDR: S5Bf2zdXP3aNe+BBpIvUsttjN+qX+5XHAvJQbsYM/ZboEQDMS4iV8w/QuGekpKLCrwJFuE0jIX 9nWX5xV5W5aQ== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="169675983" X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="169675983" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 13:42:13 -0700 IronPort-SDR: R4uohEB8K1QQi151sRe6AL3tJMP/NxpriDHVUMnTwLGwM5PtkNGAzZCJtYhAiuBrn0tzFa9wb1 LR0qg3Hnaudw== X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="407978314" Received: from isutskov-mobl.ger.corp.intel.com (HELO egrumbac-mobl1.lan) ([10.251.189.99]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 13:42:11 -0700 From: Emmanuel Grumbach To: kvalo@codeaurora.org Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org, luca@coelho.fi, Tomas Winkler , Emmanuel Grumbach Subject: [PATCH 1/5] mei: allow map and unmap of client dma buffer only for disconnected client Date: Mon, 22 Mar 2021 22:41:51 +0200 Message-Id: <20210322204157.102078-2-emmanuel.grumbach@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210322204157.102078-1-emmanuel.grumbach@intel.com> References: <20210322204157.102078-1-emmanuel.grumbach@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Tomas Winkler Allow map and unmap of the client dma buffer only when the client is not connected. The functions return -EPROTO if the client is already connected. This is to fix the race when traffic may start or stop when buffer is not available. Signed-off-by: Tomas Winkler Signed-off-by: Emmanuel Grumbach --- drivers/misc/mei/client.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 4378a9b25848..2cc370adb238 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -2286,8 +2286,8 @@ int mei_cl_dma_alloc_and_map(struct mei_cl *cl, const struct file *fp, if (buffer_id == 0) return -EINVAL; - if (!mei_cl_is_connected(cl)) - return -ENODEV; + if (mei_cl_is_connected(cl)) + return -EPROTO; if (cl->dma_mapped) return -EPROTO; @@ -2327,9 +2327,7 @@ int mei_cl_dma_alloc_and_map(struct mei_cl *cl, const struct file *fp, mutex_unlock(&dev->device_lock); wait_event_timeout(cl->wait, - cl->dma_mapped || - cl->status || - !mei_cl_is_connected(cl), + cl->dma_mapped || cl->status, mei_secs_to_jiffies(MEI_CL_CONNECT_TIMEOUT)); mutex_lock(&dev->device_lock); @@ -2376,8 +2374,9 @@ int mei_cl_dma_unmap(struct mei_cl *cl, const struct file *fp) return -EOPNOTSUPP; } - if (!mei_cl_is_connected(cl)) - return -ENODEV; + /* do not allow unmap for connected client */ + if (mei_cl_is_connected(cl)) + return -EPROTO; if (!cl->dma_mapped) return -EPROTO; @@ -2405,9 +2404,7 @@ int mei_cl_dma_unmap(struct mei_cl *cl, const struct file *fp) mutex_unlock(&dev->device_lock); wait_event_timeout(cl->wait, - !cl->dma_mapped || - cl->status || - !mei_cl_is_connected(cl), + !cl->dma_mapped || cl->status, mei_secs_to_jiffies(MEI_CL_CONNECT_TIMEOUT)); mutex_lock(&dev->device_lock); -- 2.25.1