Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp175615pxf; Thu, 25 Mar 2021 01:07:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxo6pOVAtglXcTQF1E4mcpO1aiLDfGK5RBdSDsbGoP7MLzXs18UtCV6XW/YExp9JRpZ90lp X-Received: by 2002:a17:906:4d85:: with SMTP id s5mr7971847eju.43.1616659662572; Thu, 25 Mar 2021 01:07:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616659662; cv=none; d=google.com; s=arc-20160816; b=IS+EZ6sQ5cuYMIAygkS9zJAoCIWm2lgsJeU6SYqL2pfo3SpDtfgvKQJrpMVPHbhy5b +UfEgm6chYkHwXwSoJqYenOBbEexW0EypP2SwOJdj+80j1CvHTUnEebFdBoPA7DmIMax QSVcfgC1imo9xIEZ2mBeCRGJ3er2Vx85ych6J9/ugDJH8Qw1WTSm6wXB1SXTpJWzGVsm Z27fKDVKYxmzY0kVCwTWl7a4HMx5j1lUEEV54Kl2QZH0nxOSYsBpyT0UGQwA7246SaI7 SIapraZHaS118t7/yPSG3VNoVwDyffvMjsHrm8CHmUdcqgCsR8N4/Ys+oMvRSYE8+dp6 KwOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ao67hxPs8P6etjufzRhSSYjFn6BgqJcvb3+K04mWsFc=; b=UqN+o8MKLldS0lDfO+EqZxpVOjhm50kuYy66qZIobcs1cDw+6qJYfTUWWohyBwAEol E89OBZ9iROFcvfg5wpg7B8jfbBh3+a4un30XVSApJivl5shInrYfuicnoR4101VyTaie 1bBRImUW30Dj25dhBPNDQo87g5ZKifQiccsG1AZeVp9FzHJRgQC8lU3rdZZnTubcBc0a vb4UvFts0+Gyy7lrMIotzGiv4rg2WB5TtCROjykJYy2lwniWhKKRtbUlDok/iUZTu3KR Kapnu5TnhQ7avKGIcaeBMQjDme4vNW9DeHmivzN1GYQYiBn7EPUpzKSm6B+2f4ohDI+0 r1ZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z23si3742332edr.25.2021.03.25.01.07.19; Thu, 25 Mar 2021 01:07:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbhCYIGa (ORCPT + 99 others); Thu, 25 Mar 2021 04:06:30 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:42742 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229944AbhCYIGP (ORCPT ); Thu, 25 Mar 2021 04:06:15 -0400 X-UUID: 915f937c9d124875b049511318f2d5d0-20210325 X-UUID: 915f937c9d124875b049511318f2d5d0-20210325 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1144540723; Thu, 25 Mar 2021 16:06:12 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Mar 2021 16:06:10 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 25 Mar 2021 16:06:10 +0800 From: Ryder Lee To: Felix Fietkau , Lorenzo Bianconi CC: Shayne Chen , , , Ryder Lee Subject: [PATCH 5/5] mt76: mt7915: keep mcu_add_bss_info enabled till interface removal Date: Thu, 25 Mar 2021 16:06:05 +0800 Message-ID: X-Mailer: git-send-email 2.18.0 In-Reply-To: <20744fae1cbe0dcc098b3112b0a5ccb0b6254587.1616657048.git.ryder.lee@mediatek.com> References: <20744fae1cbe0dcc098b3112b0a5ccb0b6254587.1616657048.git.ryder.lee@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: DF0AB339BFE85DC6CF47A159BA20BFA89C77DCB2135D7065C562ECA81C2610702000:8 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The same as mt7615. Keep BSS_INFO_BASIC enabled throughout interfaces life cycle. Signed-off-by: Ryder Lee --- drivers/net/wireless/mediatek/mt76/mt7915/main.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c index cde8c1ce3ae0..0f2a86b3aa9d 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c @@ -256,7 +256,8 @@ static void mt7915_remove_interface(struct ieee80211_hw *hw, struct mt7915_phy *phy = mt7915_hw_phy(hw); int idx = msta->wcid.idx; - /* TODO: disable beacon for the bss */ + mt7915_mcu_add_bss_info(phy, vif, false); + mt7915_mcu_add_sta(dev, vif, NULL, false); mutex_lock(&dev->mt76.mutex); mt76_testmode_reset(phy->mt76, true); @@ -544,9 +545,9 @@ static void mt7915_bss_info_changed(struct ieee80211_hw *hw, } } - if (changed & BSS_CHANGED_BEACON_ENABLED) { - mt7915_mcu_add_bss_info(phy, vif, info->enable_beacon); - mt7915_mcu_add_sta(dev, vif, NULL, info->enable_beacon); + if (changed & BSS_CHANGED_BEACON_ENABLED && info->enable_beacon) { + mt7915_mcu_add_bss_info(phy, vif, true); + mt7915_mcu_add_sta(dev, vif, NULL, true); } /* ensure that enable txcmd_mode after bss_info */ -- 2.18.0