Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/3] mt76: mt7615: 0-terminate firmware log messages
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
References: <20210326205505.74383-1-nbd@nbd.name>
 <249e2022c17f2555445061e533353ccd6f9e9b60.camel@sipsolutions.net>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <a1aeb214-cb3a-0c7b-1a6a-7b538d86d985@nbd.name>
Date:   Fri, 26 Mar 2021 22:53:23 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <249e2022c17f2555445061e533353ccd6f9e9b60.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2021-03-26 22:09, Johannes Berg wrote:
>> 
>> +	skb->data[skb->len] = 0;
>>  	wiphy_info(mt76_hw(dev)->wiphy, "%s: %s", type, data);
>>  }
>> 
> 
> Are you sure there's always enough space to write to the skb? Following
> the code up I'm not even sure it's always a linear skb :-)
> 
> Might be safer/better to do
> 
> 	wiphy_info(..., "%s: %*s", type, skb->len - sizeof(*rxd),
> data);
> 
> instead?
Maybe it does trust the firmware too much. I'll send a v2 based on your
suggestion.

Thanks,

- Felix