Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3165921pxf; Sun, 28 Mar 2021 14:38:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1+tRkkLf5VMQJDbazvQAleegqhXcZpn8eEAlFGSV2rpkuC8kiK9RKi3T4eZRas2PlYQys X-Received: by 2002:a05:6402:440d:: with SMTP id y13mr26089327eda.316.1616967534429; Sun, 28 Mar 2021 14:38:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616967534; cv=none; d=google.com; s=arc-20160816; b=iIJXe/3ytFn/fD7OroVV3RqXDaQtqmaW6NA5aLy6pb9t9jjwTAiJ5NnA3vGXlrLGRc HKvgiTfp4fjIqq4Xdy3taOAD1hsHzj9lE20eyeJlK8hqQBXklfh8au+t/+C4Sn/jBATS LTCPwkKNtqliPzi/23e41b8BX8CLmBljSf82gfl3V5od1l+jzEpgCZ0KYgRp6MRb65ZH vUTUxrTy1it+URxOMhfPc8hYphTtzepvoxbUVftdDyIAFu8CzLOKIx6h25mSwgZqtQGV 2mvc0DvMuHs/Df/w/R6LRMXuD0g3x2clAiVKtqk88qiR5f7QP9sBCo8tISdpZ2yxWkj8 Y/3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MUHQU3AEXaphXLycBcaQSt90DxdFLDAsT+qZsP7GzPE=; b=iGZuE++TwHCoY/zvSp3zsTK8YfuKWwh6awyG3s5fWHdxcCzeMfCo0g1rp9/azBK69I k7zoP0gDRcIOvR32Q/nNlVf33cUzTJ0AzGHJwJwRQVqv2uSOmfIcrYlYIFcdc69NtgUC DIMm20d/s0OD0s8PkHr9xXyAaD84uksg4WIGBnd5NVIbWRgFwYrwlsW6XTcn5gfgjL2q VXWfsZoHgnW5cuFwUXuagY58le4SpuFthm0kBG0IqOCcweaH2d7Ma5n3Vga0UUZ3O3un /O3QWGuJTPjArIusIsI/QqY4W29SuxvqCYGQr6d77NA0/KIm7cbcBfiuiwn2GCWL2vRp iICw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c25si10916627edw.293.2021.03.28.14.38.29; Sun, 28 Mar 2021 14:38:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231446AbhC1Vhx (ORCPT + 99 others); Sun, 28 Mar 2021 17:37:53 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:41798 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230184AbhC1Vhe (ORCPT ); Sun, 28 Mar 2021 17:37:34 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lQd6A-0005bJ-3e; Sun, 28 Mar 2021 21:37:30 +0000 From: Colin King To: Johannes Berg , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mac80211: remove redundant assignment of variable result Date: Sun, 28 Mar 2021 22:37:29 +0100 Message-Id: <20210328213729.65819-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Colin Ian King The variable result is being assigned a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- net/mac80211/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index 5d06de61047a..2fba9db56e47 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -1684,7 +1684,7 @@ static bool __ieee80211_tx(struct ieee80211_local *local, struct ieee80211_sub_if_data *sdata; struct ieee80211_vif *vif; struct sk_buff *skb; - bool result = true; + bool result; __le16 fc; if (WARN_ON(skb_queue_empty(skbs))) -- 2.30.2