Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp246212pxf; Wed, 31 Mar 2021 02:14:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJM4DMHQGi374pVdMNKnaNlw7C7uEX9xQw9RNDdwTdZc3Dj8ukBU4+Yh+l0PCsl8N7rWe+ X-Received: by 2002:a17:907:7699:: with SMTP id jv25mr2360684ejc.363.1617182096224; Wed, 31 Mar 2021 02:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617182096; cv=none; d=google.com; s=arc-20160816; b=zQcVs7PCwyDLAVd4QIeuWjGZxRM7zJ6622aE3knO6Udur57nJhsmUJCfmYnY3sLP3V nZG2oZDmzNOIyAkes59DCkPVwroCL6XouFOgCoKtybqkOc3bzIU4UxyGao+tUQtCCPwz fydgaLMGUAjjehpfGPHLgCV9s0mXZqvO8sdfhcgoEEt8KlFMQYBsPbX4V3ZFI9Z3hIQG fSIvlTTZtHREG1UYU6TbHQr3PqQiPfIULC8Sah/C9qfSl/WTGYurTCBPNNTWNGog0mg1 Bw1RrJT4oTbuNKn8ulsXBXikGssHs/IN8t1Cl4Xy+/q/DnVvGNRQdaCZgdMZB7oY9blj 5AjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=by5c6KEYcnf+Rdq2EMugh2sd1/3SpRQVyAItePsHro8=; b=YspeoXxsqdRy90s61xQl8n0XrqOs076k+O0viUNjn9g59mGy+D44galRJAVTaiTblU zi0JguXzsMaxInTuvnjHL7r5hmBSIchGBuMLH30KTUVjIcy25BarG3QxLOKPo723oBsr xF1mjHg1BsH9sp3ENfus1EfYXvjZnLxKid+Y0WxSeXdXnhetrIvOQbsrdsQWuujfvV8n 5MDU3fO4i2f/qTshE7Eh8WmRqogFA/G90sdIn0CZRm2qW/YCmp1NMlGienU5dfnrFoEe 7WsaL3ytz6qd2Rr6bMzEmXzgCZsKXA8WtqX3m6+mNnONfheffNnUQQlh9NfHWTChkxwD 8ADg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jz18si1065839ejc.575.2021.03.31.02.14.31; Wed, 31 Mar 2021 02:14:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234548AbhCaJN5 (ORCPT + 99 others); Wed, 31 Mar 2021 05:13:57 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:56834 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234501AbhCaJNt (ORCPT ); Wed, 31 Mar 2021 05:13:49 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UTwuZub_1617182027; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UTwuZub_1617182027) by smtp.aliyun-inc.com(127.0.0.1); Wed, 31 Mar 2021 17:13:47 +0800 From: Yang Li To: pkshih@realtek.com Cc: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] rtlwifi: rtl8188ee: remove redundant assignment of variable rtlpriv->btcoexist.reg_bt_sco Date: Wed, 31 Mar 2021 17:13:43 +0800 Message-Id: <1617182023-110950-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Assigning value "3" to "rtlpriv->btcoexist.reg_bt_sco" here, but that stored value is overwritten before it can be used. Coverity reports this problem as CWE563: A value assigned to a variable is never used. drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c: rtl8188ee_bt_reg_init Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c index 861cc66..bf686a9 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c @@ -2466,8 +2466,6 @@ void rtl8188ee_bt_reg_init(struct ieee80211_hw *hw) /* 0:Low, 1:High, 2:From Efuse. */ rtlpriv->btcoexist.reg_bt_iso = 2; - /* 0:Idle, 1:None-SCO, 2:SCO, 3:From Counter. */ - rtlpriv->btcoexist.reg_bt_sco = 3; /* 0:Disable BT control A-MPDU, 1:Enable BT control A-MPDU. */ rtlpriv->btcoexist.reg_bt_sco = 0; } -- 1.8.3.1