Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp686324pxf; Thu, 1 Apr 2021 10:54:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzx/6JPuLScyonUheVs4NvuFKJfWWyiSIPGA9KfenKmFcRN23fR0IQtZHUZ3PuOgYVz54y X-Received: by 2002:a05:6e02:d0c:: with SMTP id g12mr2929745ilj.60.1617299678269; Thu, 01 Apr 2021 10:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617299678; cv=none; d=google.com; s=arc-20160816; b=mxonWLMgMrOzGgQWYmhzH84NfOrL0gjFp0ZfowTJ7ZZIskzIhel7uTP3TdFqOJbWn+ a+99DUabLDTvvaNQF+zIzd6InR7ylzjRDvpJAHuZF3qXHJDikrHMQd57Tep4v9scEedC zNAK7+Fzd+L19d0pqbzb6mqP6W8jagpx/CCO+QoqsJb/mu0A12FB7/gEFixWSfAl22oQ ohuhLGg8HtuFsOSUZs5ar0FBkyRlCNgrdWVDKWMbxNoHOpDAFyXR+fFC+av+XbnMPiTg B/XFO/LpLztpQilhArHidk1R5kADLqbUIhtj29hVZv4T5tPTEGmaiQKy6NxnJLnRl1be ZxEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject:dkim-signature; bh=NsWTNB0+vljiTVhpT7XopXbq3xQdRf2JnOJz4xm977E=; b=jnTaO6MNCFR8wHZ0AP1gB7NzTU4bEootuAY/Xce4IFtR0RhlsoRZsMFoQOZdtV5QhH xkWfHvNKy/p2iiNiyzB/pF+j8bEChSxducf3ifqQu/gSg+vhiIaE0Sh92VEiKwfSbcIZ 8Pmqo66vv0sbwZ1Y6CSrJmxqFpm0IECtZDUj7asG5/Lqqg7KOWoII/sINwu3BIoVsP8D mAXwr68cuJ9u4fk/JDgMVccE7tzbpPms7L+yXpmrYW4AWwZZBW8JDbTpz2Qp+8orgRg7 8E9uqK3ukx24hrY+FJG9bgRP0ypCs0CfBAes2zVszMlcd9krflG4x9vAxazxo4AdtDHQ o9Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=fVgN44m1; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a27si6008503jab.1.2021.04.01.10.54.24; Thu, 01 Apr 2021 10:54:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@nbd.name header.s=20160729 header.b=fVgN44m1; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235391AbhDARxC (ORCPT + 99 others); Thu, 1 Apr 2021 13:53:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236402AbhDARrM (ORCPT ); Thu, 1 Apr 2021 13:47:12 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A704C03114B for ; Thu, 1 Apr 2021 09:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NsWTNB0+vljiTVhpT7XopXbq3xQdRf2JnOJz4xm977E=; b=fVgN44m19DWTq7MzZ5CqgftEtk M3BlAur/YAKbJF5bbeaRoxkBOQ4K47JTr+FPCcfBBFqL+TT0WipsZtyCtDYRAqJ84lDu736c1gPip 6C5ctFm0KtWzWLRZ6fJeP5UPxmiqqKfB1hJERVlpfMM09s10QjniLGu9OcUqIWXIjld4=; Received: from p4ff13c8d.dip0.t-ipconnect.de ([79.241.60.141] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lS0Py-0002Ao-FG; Thu, 01 Apr 2021 18:43:38 +0200 Subject: Re: [PATCH] mac80211: fix time-is-after bug in mlme. To: greearb@candelatech.com, linux-wireless@vger.kernel.org References: <20210330230749.14097-1-greearb@candelatech.com> From: Felix Fietkau Message-ID: <1b60f9ab-6605-d595-acce-51c5cee41871@nbd.name> Date: Thu, 1 Apr 2021 18:43:35 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210330230749.14097-1-greearb@candelatech.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-03-31 01:07, greearb@candelatech.com wrote: > From: Ben Greear > > This fixes commit: mac80211: optimize station connection monitor > which came in in the 5.10 kernel. > > This incorrect timeout check caused probing to happen when it did > not need to happen. This in turn caused tx performance drop > for around 5 seconds in ath10k-ct driver. Possibly that tx drop > is due to a secondary issue, but fixing the probe to not happen > when traffic is running fixes the symptom. > > Signed-off-by: Ben Greear Acked-by: Felix Fietkau - Felix