Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4013389pxf; Tue, 6 Apr 2021 06:06:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYpj9IuVPPiLd82VZ0Cxw0tKaSW4qPYvJHdThflVwZNvqFJYcMnrdJAaFxYf4J7yUfxmJg X-Received: by 2002:a05:6638:381c:: with SMTP id i28mr28221660jav.60.1617714390720; Tue, 06 Apr 2021 06:06:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617714390; cv=none; d=google.com; s=arc-20160816; b=XbEByzaV7FkX8JB8Q6rL61NHYSsvig1ce2c6DcrC7+AREsv1H3jDZDKO825esLGj8P eUyaORrhA55ZfkmMBgdsxWKfIMTHslEaeENuPfSxhjQHfpUcGBFobd7AJLuAthYf2r3Q fHO7Sf3bW+wD7wINeqF6D6hiQYDSJD4MLui7h3Nh/BHnuZuoNg8MMt3pq8xWRrhe1uv0 dLUVBBw/L99468Hb8quAL2AGjBBCnAkY+/sY+0BWSsz+JOgZ5XArkK+B13AAANKCtGlb sLzPVopCiafFERYqYL3dX2Xm30gGXojg99iWiOi3/nGfIRc/vepaplR7AzvCi4o5bX1I lPvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=+tjm4oE8NaEzoPjmQJbJQGyVxlpOLXc5VwnLcrEcqmc=; b=ujfUB2kBCaVXjNClQrZ0vqbapsLRcg/D67f8uBeCId4YU/84w6qE9hzPMgQN7mByiP cG7k8pyuHU7OlaUirHWe5cIO2VoAfEhzm8cT0z1EZQQg4iG9IsOh34NDgrbAjPCYULC0 JP2citN5ceJ7/3j+I2BysMUD81pSJJ83iJpr9pZSQlpHcNyuxIuvmVa1vJsqnO303z4O Kc6zs0zXZ4+k0AGoC5247mlOPh/0dT9vjfhNqJwVuJtZ7Hi+PQrsAiJiZwdJncYbphcx Y52eHEXB2OvTjb9MP13ceHaBvQQkUaUmWlJE6woMcbtVKEniV/IJBlFGX0UcCCgMamJ0 CcwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v4si17091010iob.94.2021.04.06.06.06.12; Tue, 06 Apr 2021 06:06:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239201AbhDFDew (ORCPT + 99 others); Mon, 5 Apr 2021 23:34:52 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:44117 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S239413AbhDFDew (ORCPT ); Mon, 5 Apr 2021 23:34:52 -0400 X-UUID: 015b88d4585944238697adfe50eb64a8-20210406 X-UUID: 015b88d4585944238697adfe50eb64a8-20210406 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1044638343; Tue, 06 Apr 2021 11:34:42 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Apr 2021 11:34:41 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 6 Apr 2021 11:34:41 +0800 From: To: , CC: , , , , , , , , , Subject: [PATCH 5/6] mt76: mt7921: fix MT_PCIE_MAC_INT_ENABLE access Date: Tue, 6 Apr 2021 11:34:38 +0800 Message-ID: <93c38f60a5257aba24f460042df2537b459d8ab3.1617679693.git.objelf@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <4c5666ad0683e467f11ca4a4abb5be335be25696.1617679693.git.objelf@gmail.com> References: <4c5666ad0683e467f11ca4a4abb5be335be25696.1617679693.git.objelf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Sean Wang Use mt76_wr to directly access MT_PCIE_MAC_INT_ENABLE because we used the remapped address 0x10000 as the base to operate PCIe interrupt. Fixes: 215bb6737bef ("mt76: mt7921: add wifi reset support") Signed-off-by: Sean Wang --- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c index 94f178e28e20..3bbd8bc0315f 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -1321,7 +1321,7 @@ mt7921_mac_reset(struct mt7921_dev *dev) mt76_connac_free_pending_tx_skbs(&dev->pm, NULL); mt76_wr(dev, MT_WFDMA0_HOST_INT_ENA, 0); - mt7921_l1_wr(dev, MT_PCIE_MAC_INT_ENABLE, 0x0); + mt76_wr(dev, MT_PCIE_MAC_INT_ENABLE, 0x0); set_bit(MT76_MCU_RESET, &dev->mphy.state); wake_up(&dev->mt76.mcu.wait); @@ -1364,7 +1364,7 @@ mt7921_mac_reset(struct mt7921_dev *dev) clear_bit(MT76_MCU_RESET, &dev->mphy.state); mt76_wr(dev, MT_WFDMA0_HOST_INT_ENA, 0); - mt7921_l1_wr(dev, MT_PCIE_MAC_INT_ENABLE, 0xff); + mt76_wr(dev, MT_PCIE_MAC_INT_ENABLE, 0xff); mt7921_irq_enable(dev, MT_INT_RX_DONE_ALL | MT_INT_TX_DONE_ALL | MT_INT_MCU_CMD); -- 2.25.1