Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp220611pxf; Thu, 8 Apr 2021 01:14:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuCBlB+3cFu6xqJ4IyF7ln3FCxb009dJmIMol+SquEtJbeyIINknl7HHgBSq+r3O0oCbfF X-Received: by 2002:a17:90a:7444:: with SMTP id o4mr7203906pjk.205.1617869665439; Thu, 08 Apr 2021 01:14:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617869665; cv=none; d=google.com; s=arc-20160816; b=UEQs9J5+QvOqd7hrl5SEIX4POchCDsSO03Vfj2pBG851OHVuZamh4nuIcarNkTHgsk CcAsdP08Hu3kP8HyNyOo/rVL4fHH/9sbeUmCDDjVSCAyFWKho/BMcNegDHKix8lNT87I dEPxu8WUTRXvotd8AynMr2t6RKNE4aF/U9BtO0/kyTPA379qchsEeuX8nhfXp0mP+6K9 APYlxq9734Dq90NAkoNcZnvVn2MQ4JfZ7iK4I3vxn0azyqvnFWjzh9iAcZTGXBteQYi+ aacol1f3RButWh5dWu8q4pbII05X+4W8KZCorjzZlXBDXNsNXG672T2v+2mpkwSklFAl 4Y4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=BpyFDqA8yfPqfXL5Ss+kZslnLHkDNISClKe7z/uR3X4=; b=aBe9N1WZW3mvK/UEao6eKNXD/PH2pCcjw1b/lnPqX7zbbCsjeXn9s0Tz3Tc0H6+R7V YJJr3KIRK456jUqTv63Eo4QWk9UAyorz5kqwJ1naAWCrxEzFSATt+aiYFohGtyCrWs+Y GuO7kKfJhVDWzdpesqDfhWa+t6gpPQSOVwn2AZGS+HIH2payCff4BKquHKX9Lr2hAnDm 6n+F7/hXTw5iNBNm3XfHvBzqg9P9id+VkYdOfXvGsvA+TG4wqfvTNlHxVjjq9Pr54W5K pQz712xr8oE0ppSbmlfqQxtegKcnUCu4UQGB7Usgf/uD0uIb/aUSOVY41LwKK7irw55s ++dg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f5si24249224pfc.57.2021.04.08.01.14.11; Thu, 08 Apr 2021 01:14:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229615AbhDHIOP (ORCPT + 99 others); Thu, 8 Apr 2021 04:14:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbhDHIOO (ORCPT ); Thu, 8 Apr 2021 04:14:14 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34897C061760 for ; Thu, 8 Apr 2021 01:14:03 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lUPnb-008ukb-IB; Thu, 08 Apr 2021 10:13:59 +0200 Message-ID: <4f625f7cf6b8a325b128a71bf1805dd7e334cc6b.camel@sipsolutions.net> Subject: Re: [PATCH 2/2] iw: fix ftm_request missing arguments segfault From: Johannes Berg To: Benjamin Aschenbrenner Cc: linux-wireless@vger.kernel.org Date: Thu, 08 Apr 2021 10:13:58 +0200 In-Reply-To: (sfid-20210322_155533_226282_3A77C432) References: (sfid-20210322_155533_226282_3A77C432) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2021-03-22 at 15:55 +0100, Benjamin Aschenbrenner wrote: > > @@ -282,6 +282,9 @@ static int handle_ftm_req_send(struct > nl80211_state *state, struct nl_msg *msg, >      const char *file; >      int err; > > + if (argc < 1) > + return HANDLER_RET_USAGE; Something along the line replaced tabs by 4 spaces, so the patches don't apply. Please resend. Thanks, johannes