Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp269548pxf; Thu, 8 Apr 2021 02:42:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0arQZH5PPkWzOFnr328GxGYlIoREJHb8jfIrHCG9fCwtWQb0lazdIGMrwKuH4CT7QzuHm X-Received: by 2002:aa7:d54c:: with SMTP id u12mr10430872edr.234.1617874968835; Thu, 08 Apr 2021 02:42:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617874968; cv=none; d=google.com; s=arc-20160816; b=dyJLgdmm/v5IDfmRFJpnvFd9ku6sjtjTcViZj8jVgip8ZoDjqRaCqZezNIGkgL0iXF Gw3UwDisRvr83RbBjz6GvotSnOKzB6KbNORry+cqqHE8EXCLQJ2hz3uyVJ1dv+o3Y/FI vqP8yVmhF+HkYbgUox2e8BOvE79jHQtnrC8LQ4oin1llNHj3hEs9Z4W5npQYGFiT2GVC FyZton8tfJNbjUEG5m1BNyqJaF7g1N9Zajd8I9i6uflpAmduU6mWTxKWikZXdne6cbXN nBoIIzlnnSWlqCv4lRBx3/eNWOWcuPF0b+B/cKw+h3G7Une66Eq3xNdA0H1HIAclokv3 4WgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=LlycAaHURux0nVPrE0fkw39+XWOpKwbZ4+LMa0pnz3I=; b=t64NMvgoWRhPRgXOd9CVYyVyI/ZBh7C4fuM92trPuYRZNVebGroNX+Skvbwe6JbbtL D/eBBHN9/JwhdG8Q/kJlOi0xF5jKRBTU/UUp4Dxy5xNB+rjSOcXa0tq03S1kiVtwT0uK iJ4JheobSGO8VKF+4+c+Anea8slrQeRs2rQdzKbM70h8T0iM3F1TSmtnn+7C6+JiSgtz RBw0PVGSGhy25yFAYevJ42ZP2ymLYF+nAU6KeBRwPOPOKW6RpnjUL4JP77T9edqhzR+p gUYMryvdOtxHP/FC3Awcq/pyMtSR9m8RTHSZDlGkNtY0uPMi6LNDaGmyAochebm17NSg DhYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si9006388edz.407.2021.04.08.02.42.21; Thu, 08 Apr 2021 02:42:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231158AbhDHJjq (ORCPT + 99 others); Thu, 8 Apr 2021 05:39:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230506AbhDHJjp (ORCPT ); Thu, 8 Apr 2021 05:39:45 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 931DBC061760 for ; Thu, 8 Apr 2021 02:39:34 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lUR8H-008wRl-Km; Thu, 08 Apr 2021 11:39:25 +0200 Message-ID: <246a7cca8e90c947e38caa9ddf1d028d9ae10bb7.camel@sipsolutions.net> Subject: Re: [PATCHv2] mac80211: increment rx stats according to USES_RSS flag From: Johannes Berg To: Thiraviyam Mariyappan , ath11k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Date: Thu, 08 Apr 2021 11:39:24 +0200 In-Reply-To: <1613563010-1489-1-git-send-email-tmariyap@codeaurora.org> (sfid-20210217_125904_154301_738B3086) References: <1613563010-1489-1-git-send-email-tmariyap@codeaurora.org> (sfid-20210217_125904_154301_738B3086) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2021-02-17 at 17:26 +0530, Thiraviyam Mariyappan wrote: > Currently, rx_stats were updated regardless of USES_RSS flag is > enabled/disabled. So, updating the rx_stats from percpu pointers > according to the USES_RSS flag. I guess I'll fix it this time, but the commit log is still not saying what it should. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_messages Please, everyone @codeaurora, pay attention. I don't want to have this discussion for every patch. johannes