Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <cb0a3bac83f4e56c7b1c0b049080d4f4186bed72.camel@sipsolutions.net>
Subject: Re: [PATCH 1/3] nl80211: Add support for beacon tx mode
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Sven Eckelmann <sven@narfation.org>, ath11k@lists.infradead.org,
        linux-wireless@vger.kernel.org,
        Maharaja Kennadyrajan <mkenna@codeaurora.org>
Date:   Thu, 08 Apr 2021 13:11:34 +0200
In-Reply-To: <2718995.X0rUDs3ZmB@ripper> (sfid-20210222_113458_463202_DAC50CAC)
References: <1613988573-10839-1-git-send-email-mkenna@codeaurora.org>
         <1613988573-10839-2-git-send-email-mkenna@codeaurora.org>
         <2718995.X0rUDs3ZmB@ripper> (sfid-20210222_113458_463202_DAC50CAC)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-02-22 at 11:32 +0100, Sven Eckelmann wrote:
> On Monday, 22 February 2021 11:09:31 CET Maharaja Kennadyrajan wrote:
> > User can configure the beacon tx mode while bring-up the AP
> > or MESH. Hence, added the support in the nl80211/cfg80211
> > layer to honour the beacon tx mode configuration and pass
> > this value to the driver.
> 
> There is not a definition what this actually means. But I am guessing that you 
> are mean the way the HW sends our the beacons for a multivif (beaconing) 
> setup. And in this case, it is a per "phy" setting and not a per AP/meshpoint 
> setting, right?

In addition, the commit logs are not explaining anything, why you'd use
it, why it's necessary, etc.

I'll say it again: @codeaurora folks, consider the community, not just
your own driver. I'm really getting tired of having to extract
information from you.

johannes