Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7f6f0a8c151746e8bb44ad50daf75259a0fac829.camel@sipsolutions.net>
Subject: Re: [PATCH v9 2/4] mac80211: add multiple bssid support to
 interface handling
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Aloka Dixit <alokad@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, John Crispin <john@phrozen.org>
Date:   Thu, 08 Apr 2021 14:06:37 +0200
In-Reply-To: <20210310182604.8858-3-alokad@codeaurora.org> (sfid-20210310_192729_241525_2DF37B20)
References: <20210310182604.8858-1-alokad@codeaurora.org>
         <20210310182604.8858-3-alokad@codeaurora.org>
         (sfid-20210310_192729_241525_2DF37B20)
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2021-03-10 at 10:26 -0800, Aloka Dixit wrote:
> From: John Crispin <john@phrozen.org>
> 
> Add a new helper ieee80211_set_multiple_bssid_options() takes propagating
> the cfg80211 data down the stack.
> 
> The patch also makes sure that all members of the bss set will get closed
> when either of them is shutdown.

s/either/any/
> 
>  static int ieee80211_del_iface(struct wiphy *wiphy, struct wireless_dev *wdev)
>  {
> +	struct ieee80211_sub_if_data *sdata;
> +
> +	sdata = IEEE80211_WDEV_TO_SUB_IF(wdev);

can be one line

> +	if (sdata && sdata->vif.type == NL80211_IFTYPE_AP) {
> +		if (sdata->vif.multiple_bssid.flags & IEEE80211_VIF_MBSS_TRANSMITTING) {
> +			struct ieee80211_sub_if_data *child;
> +
> +			rcu_read_lock();
> +			list_for_each_entry_rcu(child, &sdata->local->interfaces, list)
> +				if (child->vif.multiple_bssid.parent == &sdata->vif)
> +					dev_close(child->wdev.netdev);
> +			rcu_read_unlock();

You never tested this properly, this is wrong.

johannes