Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp395582pxf; Thu, 8 Apr 2021 05:32:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz92m1AhBTLwkCLXmlvT/L/dwSc2qv9IioxrZtB9LdyFzBMw4BBcp7fYf9qdYhVCfIJL6oj X-Received: by 2002:a17:90a:414e:: with SMTP id m14mr8003050pjg.9.1617885173036; Thu, 08 Apr 2021 05:32:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617885173; cv=none; d=google.com; s=arc-20160816; b=M03ZYhbcU4DjXkOoHkt+KzXnKhE7aesGbAN9CwKMCW0irSrp8rtBU51CZlmN/0FBgv 7BCFW1V8gBP6mnAWSLFOjyGIy3GcmvJH5RD+kquVRKjhXQd2vHq8g7TA03dakCvQAZQv jECSu6+1sJhvOtOKApxWWWjaY8khFlKtqbKDLSc7FjRBGjCB1MT2uDgd1nUssaS6Vjex bONg79SI48sZkwABhHcNpn1TIp0bCva1r35O2QSCYisrx5swnaQrtFryUEmhkHpbIzXM w76UH+nSDTfh5dJfOUcRZxAQ0/Rv8msbPRezyFhyKC2ax/Er5GxkdoE2CkrcsMAqKNKM lZGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ZAx3CJhOKIEOfD9CC5rslCDis2rmYXjAU+0By06wgWM=; b=XtkaIMeZSyAaa6I3MFO+fijGXtyCmNJHBQKGs1rrNwaJbsdjZVgu6vT1zRI0rQM7nv oxKJbV6xr0uEXRoBFdN7QznegaTmeIX8kbxArSoPil7g2YaulVciw+N1dgPL+QIoBuN0 imxEJVeMaVMQPj7jIzpGFmksu9WOn9PCT6wCgPa+/eMlo7V7+0WMS2pfQ1QJ55fpdjXT LrKqlAvOxk0uU5IdHuf2sVael4Y14oD8Rxm+6lBSSNUZHjaRm2eMcMIhKITLh+AYJmIf BYicswVyMbH9zvMgFunKxKeOj+sghWeuhgL6Ir32lQbo7VGkqOOewLQSjV73lPWyXKS7 I3Lw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 90si26997814plc.183.2021.04.08.05.32.39; Thu, 08 Apr 2021 05:32:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230322AbhDHMcn (ORCPT + 99 others); Thu, 8 Apr 2021 08:32:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbhDHMcj (ORCPT ); Thu, 8 Apr 2021 08:32:39 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ED09C061760 for ; Thu, 8 Apr 2021 05:32:28 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lUTpi-008zyV-Bq; Thu, 08 Apr 2021 14:32:26 +0200 From: Johannes Berg To: linux-wireless@vger.kernel.org Cc: Ilan Peer Subject: [PATCH] cfg80211: Remove wrong RNR IE validation check Date: Thu, 8 Apr 2021 14:32:24 +0200 Message-Id: <20210408143224.c7eeaf1a5270.Iead7762982e941a1cbff93f68bf8b5139447ff0c@changeid> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ilan Peer Remove a wrong length check for RNR information element as it can have arbitrary length. Signed-off-by: Ilan Peer Signed-off-by: Johannes Berg --- net/wireless/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/scan.c b/net/wireless/scan.c index 019952d4fc7d..c3b51efff5c6 100644 --- a/net/wireless/scan.c +++ b/net/wireless/scan.c @@ -589,7 +589,7 @@ static int cfg80211_parse_colocated_ap(const struct cfg80211_bss_ies *ies, elem = cfg80211_find_elem(WLAN_EID_REDUCED_NEIGHBOR_REPORT, ies->data, ies->len); - if (!elem || elem->datalen > IEEE80211_MAX_SSID_LEN) + if (!elem) return 0; pos = elem->data; -- 2.30.2