Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp1567286pxf; Fri, 9 Apr 2021 11:33:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTNPmtT+Dr2iX75jADc0K7h1EHlGNKCUggOh0W8/Y507KYW7Y6JnR0Nv1ZzhXB09LOdpaj X-Received: by 2002:a62:6202:0:b029:208:f11c:2143 with SMTP id w2-20020a6262020000b0290208f11c2143mr13750752pfb.32.1617993216796; Fri, 09 Apr 2021 11:33:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617993216; cv=none; d=google.com; s=arc-20160816; b=GEp1F4cFPJ6+QWwt5bhnPAgXVqpWOOZzNeTfqPW6rpf0PQYxgOLQLi7IBb9QcH8q1G O4qeh829frudw0Ejx7i5orMQkXXPrrXO7WjQGCoRstlMRxkITT8vEP9s00KkOrhYgWgI T7VbbM1Uv0EJPcKVZBUpdNdO/RR6J/r22nZH9Ipn3dij8JBX+PUM0Oniwk8+05F2LIgD n9RN/KsIyDBa2LWEhMW4H8mclSeX4C6f6y9amvjlpW05yJZhSfd7LHXXrjgD422bsWcO 8Z+vAL3jPDiELwdyLGtww9YespcFrjcRWrRfAJALSXP0W679yaGITHB1pzRBRctaqiQW VlNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=l7DuZBcH6S8G0I8co4o9/uDuuMSudE7sOrUgkCoEiTg=; b=aCJsrfYpxsqOlBQ4PZN45sc0tPMmKxIDwf9UBECC+lsqe85A2x2yq8Zo1xMQqpCQQy //UrEpJZhZj0qO7gs8PPXOTCwsmB0or9k/Wt3eMzbd4bPZBjMVKhltJQWO0LVbL5n+xS /ZdJrKDjyO5cu6vvuPjoCruT+Eu9RjGNfoT+KF0+dE4tuNkVETdMk0mzn2QJuNMtxvEG aGDFBG9uTYiuS1uOaZ1zk4lI5Z2pF5cfJSoPOAT9mL9YoFq+I30gR1m60VTbP9uUF98p mdBw2f/S/oE+6SLx/Oo5mU+x2hZm7q4ILSePZseB9IjzFPCchY/l5okNqMHbL5UHwiHy IpuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=i1VTCdok; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 62si3612595ple.18.2021.04.09.11.33.21; Fri, 09 Apr 2021 11:33:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=i1VTCdok; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234273AbhDISb1 (ORCPT + 99 others); Fri, 9 Apr 2021 14:31:27 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:48699 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234049AbhDISb0 (ORCPT ); Fri, 9 Apr 2021 14:31:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617993074; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=l7DuZBcH6S8G0I8co4o9/uDuuMSudE7sOrUgkCoEiTg=; b=i1VTCdokJmGCDqW8KFiauplJP3jc427Jnh7NAuGhPkhsBhtK4yviduZTLGQPtfr1cnezeEwD Wmi/kOEeOb6L+p0FIFsjFK0VZnvrh7ptV+F/WNky5reran9AdW2KS/XkJ6+gjtCuxgV7QHqS OQkzCn9cwolPhxH7ijxIkAWQEqY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 60709d6a8807bcde1d16e942 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 09 Apr 2021 18:31:06 GMT Sender: alokad=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 18EB3C433C6; Fri, 9 Apr 2021 18:31:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: alokad) by smtp.codeaurora.org (Postfix) with ESMTPSA id 66837C433CA; Fri, 9 Apr 2021 18:31:04 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 09 Apr 2021 11:31:04 -0700 From: Aloka Dixit To: Johannes Berg Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH v9 0/4] Multiple BSSID support In-Reply-To: References: <20210310182604.8858-1-alokad@codeaurora.org> (sfid-20210310_192727_681722_4BC25758) Message-ID: <2427e22bdd9e34aec0667a78dd8d6537@codeaurora.org> X-Sender: alokad@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-04-08 05:17, Johannes Berg wrote: > On Wed, 2021-03-10 at 10:26 -0800, Aloka Dixit wrote: >> This patchset adds support for multiple BSSID and >> enhanced multi-BSSID advertisements. >> >> This version modifies only nl80211 patch (1/4) which describes >> the difference. >> >> John Crispin (4): >>   nl80211: add basic multiple bssid support >>   mac80211: add multiple bssid support to interface handling >>   mac80211: add multiple bssid/EMA support to beacon handling >>   mac80211: CSA on non-transmitting interfaces > > Also, can we have hwsim support for proper testing? Seems with all the > logic in mac80211 to give you the right beacons etc. that should be > really simple? > > johannes Sure, will add hwsim tests. BTW, do you see value in replacing all occurrences of *_multiple_bssid_* with *_mbssid_* (also in new nl80211 attributes). Most lines needed to be split because of 80 character boundary, so this replacement will make that code look cleaner. I have avoided it till now to reduce number of changes between versions. Thanks.