Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Apr 2021 23:27:13 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        lorenzo.bianconi@redhat.com, sean.wang@mediatek.com,
        ryder.lee@mediatek.com, shayne.chen@mediatek.com,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 1/8] dt-bindings:net:wireless:ieee80211: introduce
 regdomain property
Message-ID: <YHDGsYmuYmP80ICh@lore-desk>
References: <cover.1617625912.git.lorenzo@kernel.org>
 <1ff764d84e1fb83768c2e9d233c27b0ed1ef4294.1617625912.git.lorenzo@kernel.org>
 <20210409151324.GA3662358@robh.at.kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="y4CXlUu0agZS+St2"
Content-Disposition: inline
In-Reply-To: <20210409151324.GA3662358@robh.at.kernel.org>
Precedence: bulk


--y4CXlUu0agZS+St2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Mon, Apr 05, 2021 at 02:40:25PM +0200, Lorenzo Bianconi wrote:
> > Add regdomain property to ieee80211 binding
> >=20
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  .../devicetree/bindings/net/wireless/ieee80211.yaml      | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.y=
aml b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> > index d58e1571df9b..6557c6348cac 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.yaml
> > @@ -30,6 +30,15 @@ properties:
> >        different 5 GHz subbands. Using them incorrectly could not work =
or
> >        decrease performance noticeably
> > =20
> > +  regdomain:
> > +    minItems: 1
> > +    maxItems: 1
> > +    contains:
>=20
> If only 1 entry, then 'contains' is pointless. Just 'enum' is enough.=20
> You also need a 'description'.

ack, I will fix it in v2 moving it in mt76.yaml patch

Regards,
Lorenzo

>=20
> > +      enum:
> > +        - FCC
> > +        - ETSI
> > +        - JP
> > +
> >  additionalProperties: true
> > =20
> >  examples:
> > --=20
> > 2.30.2
> >=20

--y4CXlUu0agZS+St2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYHDGrgAKCRA6cBh0uS2t
rJaoAQD8hu+pN4T2G5mVXS2ffyj+GbhRE7mYJy2jasOHYj/P+QEAthlYPEt6EHsh
T8B/LJK4DvbgbQugALPWZS/ou6BynA4=
=CiW1
-----END PGP SIGNATURE-----

--y4CXlUu0agZS+St2--