Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp933112pxb; Sun, 11 Apr 2021 02:04:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFM3vXeHEM6LJCcQyLzYpvPL5SWB8hseKy9SBmFoXyQnXxDBr6jbocknOEkP9fZS13PE6a X-Received: by 2002:a17:906:5383:: with SMTP id g3mr23301808ejo.185.1618131857152; Sun, 11 Apr 2021 02:04:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618131857; cv=none; d=google.com; s=arc-20160816; b=FzXJod480Cl8kRl53wc5UE2EPCGjBkI8rup2upK5/81cbC9/j7lpDkJYkt/8I0JQJl uWDStGBd+xk7zl69N9u2+eJkN9PzdBRvJfAZIm5RFVmSdQAdu91HevCaEb/vE9/IEHe8 bUa5eb6Pq+zCzUlOBq50WLAhZ84BZz9lh2yqJB6Cd9ZZc2SEjEdn5QAT2bMkFNwEnuod IkzpFZd51zRIp+mjLz02kEiD9tuZpHQQTaOZoJZCQQL59joJoCOFkdtDlmUJx5Dp3rci cqEaHDcB3qR4Tg5soWJJnRpu8IIqq8xI3XJbWJxBqMZxoIwkY9ll1GTlb9b0/T766eui ncoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=a2G7vTFDh+Q+9V1OXanbd//eBGo5z3KYcHHK6KjCCtA=; b=M9k/EIy+WNcHUmeUxSFiIJE7qe1velJl51LM+nI7LMrM+wA5HtLaAIXwmmON3oGsrA BZnodiVSQgkf+HGASpXb8gBTMJunnH7jZFe11zSzY468EJ8LOg+BhPbjDs5hZQShij7r tJ8pjkN+NO6v3RLfi7/EVdI85RDVfBmX8CZuLgmBBC8v2lVZXCUFexrd/SWczhBg2I1C 3X5NrX8oT7dnm80bcnGCetvLVGhugSOnPTHDKUUz2yc/gq1Qvhoc3SgoYtm6NvLboy9X aOGrBrIIvH1i9C3Y+Xgobev0CMyPx3+tNQFXp5BIIqVR1PJKpu02u2HE7uQnrgcJyfHc UmbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=MW5ypptE; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t7si5439704ejb.509.2021.04.11.02.03.36; Sun, 11 Apr 2021 02:04:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=MW5ypptE; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233514AbhDKIsI (ORCPT + 99 others); Sun, 11 Apr 2021 04:48:08 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:39600 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbhDKIsH (ORCPT ); Sun, 11 Apr 2021 04:48:07 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618130872; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=a2G7vTFDh+Q+9V1OXanbd//eBGo5z3KYcHHK6KjCCtA=; b=MW5ypptELoWOdUw/6VZxH3fWfWLumF18e2P6Ufw8Rv/JiWwS2nobURZpYUkbhqsV+hsRtBjf fl01OhMWBsKPZGSj8/6EFBRfQc7KPapZs5Evrt4/zffSJdnmfBlBLG0fnd737Pzr6UUR7mzu YIHGgrrEuqwo/lX9reJy+HXPCfs= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 6072b7b6febcffa80fe7ed3d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 11 Apr 2021 08:47:50 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D976AC43461; Sun, 11 Apr 2021 08:47:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3C805C433C6; Sun, 11 Apr 2021 08:47:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3C805C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 5.12] mt76: fix potential DMA mapping leak From: Kalle Valo In-Reply-To: <20210323214737.53254-1-nbd@nbd.name> References: <20210323214737.53254-1-nbd@nbd.name> To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, greearb@candelatech.com User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210411084750.D976AC43461@smtp.codeaurora.org> Date: Sun, 11 Apr 2021 08:47:50 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau wrote: > With buf uninitialized in mt76_dma_tx_queue_skb_raw, its field skip_unmap > could potentially inherit a non-zero value from stack garbage. > If this happens, it will cause DMA mappings for MCU command frames to not be > unmapped after completion > > Fixes: 27d5c528a7ca ("mt76: fix double DMA unmap of the first buffer on 7615/7915") > Cc: stable@vger.kernel.org > Signed-off-by: Felix Fietkau Sorry, I missed this and I suspect it's now too late for v5.12. Felix, can you instead take this to your tree so that we can get this to v5.13? I assigned this to you on patchwork. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210323214737.53254-1-nbd@nbd.name/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches