Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D562CC433CA
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH 2/7] rtw88: follow the AP basic rates for tx mgmt frame
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20210319054218.3319-3-pkshih@realtek.com>
References: <20210319054218.3319-3-pkshih@realtek.com>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <tony0620emma@gmail.com>, <linux-wireless@vger.kernel.org>,
        <ku920601@realtek.com>, <phhuang@realtek.com>,
        <shaofu@realtek.com>, <steventing@realtek.com>,
        <kevin_yang@realtek.com>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20210411092102.40EE7C43461@smtp.codeaurora.org>
Date:   Sun, 11 Apr 2021 09:21:02 +0000 (UTC)
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Shao-Fu Cheng <shaofu@realtek.com>
> 
> By default the driver uses the 1M and 6M rate for managemnt frames
> in 2G and 5G bands respectively. But when the basic rates is configured
> from the mac80211, we need to send the management frames according the
> basic rates.
> 
> This commit makes the driver use the lowest basic rates to send
> the management frames and a debufs entry to enable/disable force to use
> the lowest rate 1M/6M for 2.4G/5G bands.
> 
> obtain current setting
> cat /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates
> 
> force lowest rate:
> echo 1 > /sys/kernel/debug/ieee80211/phyX/rtw88/basic_rates
> 
> Signed-off-by: Shao-Fu Cheng <shaofu@realtek.com>
> Signed-off-by: Yu-Yen Ting <steventing@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Why is a debugfs interface needed?

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210319054218.3319-3-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches