Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp952516pxb; Sun, 11 Apr 2021 02:48:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzycd1N5tCqmh5P4nZkho8Mz0t7aEm0G19bbvWIZbEM6KvmkNHcNCJ+SiWazQEZMNdF8ze X-Received: by 2002:a17:907:75cc:: with SMTP id jl12mr13163188ejc.52.1618134481733; Sun, 11 Apr 2021 02:48:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618134481; cv=none; d=google.com; s=arc-20160816; b=bYB7QVnY5ml9F5G77DfGb48mfEezEVC3CYQee8fnff8dQ1bg1q0gIMDzhjQ+aTCZUd e3fcfgCjsquGrNXYP6OiG/gjfGnCo8mRsgUCSQ81wLyQp5/8EwWQaMS5imPcEHlG1ldt fBdzWSSogbEg9m2+C6z4X9mnmpzabFnaYpkHnPIQs1JhQ9dbwITB6YejyubtsJxGCy4Q IKvcQxoMVaKvqJCC/GWEyuaAgw4Fy2RlJFKFzpAn4bCmcQtrCnGwhxCL1EA2toSUeM6D ipOOhdbovMSmUXqtq1lffWB3A6Nful+zW0aeGd0sRl0bYbIbJjhe4NUckUMSVvdjxzwq ZStQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=XfQxRgEBEe5jHReIpdFXgHDUazmtIYyGrpRr5U6xjpo=; b=c0VKDQGQMiIiJIJl4wW2m9AKy5k/EzWSZtFuUfjIUzVUUOO3vra0Cs4YQFUYR2Wyko AA+bTIgS25xeK71VyPza6OIXbwwbgs/q06TKWdRWIDFYwi5xTZbVoWlUKr8M/zf8NZ0l SmM5gRBh8e6alLzLcXToMluU74Is4ybrwtHDF6B5/B5BYQcP+movsSqLZ9kdW5NbjEDa azjAIILkx8heIZMnemi/22dIVIf1Nf/qmWB71Q+eSpX6mytAu1Fq4mzp2U2XlVY8hQoS 1IqX2rS/sxFTFRoULs6Z7uSid11KxyZEhGYL0Qriv7p9U8UwKbiAwVRynSmxEZWOeWRz sDJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si6326978edv.334.2021.04.11.02.47.39; Sun, 11 Apr 2021 02:48:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235369AbhDKJra (ORCPT + 99 others); Sun, 11 Apr 2021 05:47:30 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:44450 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235331AbhDKJrZ (ORCPT ); Sun, 11 Apr 2021 05:47:25 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=kveik.lan) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lVWfs-000Jkq-8D; Sun, 11 Apr 2021 12:46:37 +0300 From: Luca Coelho To: kvalo@codeaurora.org Cc: luca@coelho.fi, linux-wireless@vger.kernel.org Date: Sun, 11 Apr 2021 12:46:24 +0300 Message-Id: X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210411094630.431873-1-luca@coelho.fi> References: <20210411094630.431873-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.5-pre1 (2020-06-20) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP,TVD_SUBJ_WIPE_DEBT autolearn=no autolearn_force=no version=3.4.5-pre1 Subject: [PATCH 06/12] iwlwifi: mvm: remove PS from lower rates. Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Mordechay Goodstein Power save (PS) should only be enabled when we reach the max phy rate. Before we reach it (MCS_9) for VHT, we should keep trying to improve the throughput. Signed-off-by: Mordechay Goodstein Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c index 91b6541d579f..b97708cb869d 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only /****************************************************************************** * - * Copyright(c) 2005 - 2014, 2018 - 2020 Intel Corporation. All rights reserved. + * Copyright(c) 2005 - 2014, 2018 - 2021 Intel Corporation. All rights reserved. * Copyright(c) 2013 - 2015 Intel Mobile Communications GmbH * Copyright(c) 2016 - 2017 Intel Deutschland GmbH * @@ -1926,9 +1926,7 @@ static bool rs_tpc_allowed(struct iwl_mvm *mvm, struct ieee80211_vif *vif, if (is_ht(rate)) return index == IWL_RATE_MCS_7_INDEX; if (is_vht(rate)) - return index == IWL_RATE_MCS_7_INDEX || - index == IWL_RATE_MCS_8_INDEX || - index == IWL_RATE_MCS_9_INDEX; + return index == IWL_RATE_MCS_9_INDEX; WARN_ON_ONCE(1); return false; -- 2.31.0