Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp954517pxb; Sun, 11 Apr 2021 02:53:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7A5JguOdhcgd7AlYZeX+TQZdiC7WDk4WJ34YEy3Z5d1izmSSSPbsFOHyWXdNkuEE5GXMD X-Received: by 2002:a17:906:3643:: with SMTP id r3mr22543779ejb.527.1618134790068; Sun, 11 Apr 2021 02:53:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618134790; cv=none; d=google.com; s=arc-20160816; b=XEWzUD0TaxORp9QQCcbWmgexhNfpdMU0zrWz+aefpMsx4AFWKUkDpR3f1nN/jLF2hw xXqABiwivXaAs4C/uE6fcrO+Kfe1H73niJd5LRIDWYg6UTfTAykRDbUEqDaF0369m0pS Y4tLg6oDWi7CaGVAPkg6C0e47ZgAqtGUcdJUdN+Bj3+DZ/Sbqj+AsfT0pHNHcPItac2S Kd7wF9N/3oGUTqUsxSNAVDf92iAzJeVEH//XlU0z65fS1Jjd0p5v3rmLkEw+7MwvJ9/A RqctYMPDTK9gttQ2uxE1rF+IkSUy8mvkElrSribAvc9Mlsranx7Ao7gOFqVWRRQOj9Ds zuIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:cc:to:from; bh=oA4Y3z8xEUp2qW16mODdl+Ez/0fEb7KmbSOKZR5vD4I=; b=JFSzbVoErS1hLGtEGKYZvW+YA9ohl/Wl7ZtxMn/0TvLjg7T1pww1nHr+tV2rSZ1DD6 SjikZcVEmcbG9a1eEWc7y6lhtkg3bhvulryyA7nqgwCPvePe7X22tRNJ4rcnhlAzCyPP Kl2M9dqHPJ0PKv43Xl9egEob0K44kZGvALg2xWLMxsW9bMQ+3731s88DBRpk2HBLH1aL +kPV2mXw+tiWYg6lxvOp4y7SRQyKJXWjeGhDySc6pP/5viNOfO3waxmio26YOGP6NTba tfzEq5Z+VgavGEQPEBkfv+f1JwIneEnxNI1zi//MRB8qL7czmO7AFTwQE+RFUBeuL0R8 cG0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si6326978edv.334.2021.04.11.02.52.46; Sun, 11 Apr 2021 02:53:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235365AbhDKJwH (ORCPT + 99 others); Sun, 11 Apr 2021 05:52:07 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:44478 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229804AbhDKJwH (ORCPT ); Sun, 11 Apr 2021 05:52:07 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=kveik.lan) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lVWfw-000Jkq-B9; Sun, 11 Apr 2021 12:46:41 +0300 From: Luca Coelho To: kvalo@codeaurora.org Cc: luca@coelho.fi, linux-wireless@vger.kernel.org Date: Sun, 11 Apr 2021 12:46:29 +0300 Message-Id: X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210411094630.431873-1-luca@coelho.fi> References: <20210411094630.431873-1-luca@coelho.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.5-pre1 (2020-06-20) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.5-pre1 Subject: [PATCH 11/12] iwlwifi: warn on SKB free w/o op-mode Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg If this ever happens, and it looks like some code in PCIe is a bit broken and might lead to this, we want to know without crashing, so add a WARN_ON_ONCE(). Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho --- drivers/net/wireless/intel/iwlwifi/iwl-op-mode.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-op-mode.h b/drivers/net/wireless/intel/iwlwifi/iwl-op-mode.h index e6d2e0994317..cf9c64090014 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-op-mode.h +++ b/drivers/net/wireless/intel/iwlwifi/iwl-op-mode.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ /* - * Copyright (C) 2005-2014, 2018-2020 Intel Corporation + * Copyright (C) 2005-2014, 2018-2021 Intel Corporation * Copyright (C) 2013-2014 Intel Mobile Communications GmbH * Copyright (C) 2015 Intel Deutschland GmbH */ @@ -176,6 +176,8 @@ iwl_op_mode_hw_rf_kill(struct iwl_op_mode *op_mode, bool state) static inline void iwl_op_mode_free_skb(struct iwl_op_mode *op_mode, struct sk_buff *skb) { + if (WARN_ON_ONCE(!op_mode)) + return; op_mode->ops->free_skb(op_mode, skb); } -- 2.31.0