Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1648651pxb; Mon, 12 Apr 2021 03:23:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1PfBR+o8ke2JBGs6/cnzvMRMWeWoZ/19dtiLnkGdrk7EDXE7mm+IAXPVulhn7j4Vpepaq X-Received: by 2002:a17:90b:2303:: with SMTP id mt3mr7328322pjb.167.1618223020594; Mon, 12 Apr 2021 03:23:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618223020; cv=none; d=google.com; s=arc-20160816; b=TUGkawbjCNd+mdwxOh2G0EnxD+FLVSBi6dU/tGl5dxBZR/oQi/Gg2p8S+3ZtEydG8p kj1QulI0oQs3Wems0eLWCz0HXRoLTQaU3BkPYb3UnU+oKrt8nJ8Wn7NitIGojaP2jijx xWOQDl+DSXYH7ScvhwXf5dWys3pEY+k1ZVeiTB45nBajR7nObZIn/+n/88isQPsT2dAJ foctV97c13UUb7p1TYNwKeY+UYYGwdVtFhId6071dvJ4XPxjMy0Lyb4xexgq4EvFJj4l zaOvspQsbAg45TG4k7IpF7nE1lJ/TqOiXgvFX9Cq6kqza3yoZehDWd421jqCU/SufiaK jdUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:message-id; bh=uMtftUv2hScGb+dbFoaxD0wyp2gdMOXK7h77A/boOdc=; b=Ruwo3mLuPc3LQBcexB/oouIqHhy9A30y/vEcvG/QqvR/jFGHVLJG6f7f7p6Ha01sBW Ok/swP0ETCPtZLfvZN15oF7iReISULS6QwTAbiMZIQrjyF6DqY4TkSmvSPt14QG32zg1 U9kSymjfKOvtqiKQ5mGmxmZSMFyTYAf5rkPS07OG1qBkZ/tlXy2YDpzQxNA4t14gGl58 9cnI3GcIfHZM4qG0aXwTtxjxu/Lx0cL1YsvqlUZMBZEX7efifNXy5s83qOYrccX2r4Lh TLrNQgyqxG53cukStko6D0I0xJrC/+EVUpIXvEDAH24grwd17vo6BHDg6hwfu5GRSUEg uM5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s11si6741010plq.360.2021.04.12.03.23.26; Mon, 12 Apr 2021 03:23:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239072AbhDLKXB (ORCPT + 99 others); Mon, 12 Apr 2021 06:23:01 -0400 Received: from paleale.coelho.fi ([176.9.41.70]:44588 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S238845AbhDLKWy (ORCPT ); Mon, 12 Apr 2021 06:22:54 -0400 Received: from 91-156-6-193.elisa-laajakaista.fi ([91.156.6.193] helo=[192.168.100.150]) by farmhouse.coelho.fi with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lVtiD-000Kw4-2V; Mon, 12 Apr 2021 13:22:34 +0300 Message-ID: From: Luca Coelho To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org Date: Mon, 12 Apr 2021 13:22:32 +0300 In-Reply-To: References: <20210331091452.543321-1-luca@coelho.fi> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.4.5-pre1 (2020-06-20) on farmhouse.coelho.fi X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, TVD_RCVD_IP autolearn=ham autolearn_force=no version=3.4.5-pre1 Subject: Re: [PATCH 05/12] iwlwifi: pcie: try to grab NIC access early Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2021-03-31 at 12:14 +0300, Luca Coelho wrote: > From: Johannes Berg > > Sometimes some NICs may fail to initialize, but if we have > such a scenario we may only see an alive timeout (i.e. the > firmware doesn't send us the alive message), and that will > only cause us to fail the interface up. > > Try to once grab NIC access during device probe to ensure > we can properly talk to the hardware at all, and to do all > the potential workarounds in that function. > > Since we now finish NIC init here, we can remove it from > the later potential read of the RF ID. > > Signed-off-by: Johannes Berg > Signed-off-by: Luca Coelho > --- This patch is included in Emmanuel's iwlmei series, so I'll drop it from this series. -- Cheers, Luca.