Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D84F9C433C6
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Pkshih <pkshih@realtek.com>
Cc:     "tony0620emma\@gmail.com" <tony0620emma@gmail.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        DeanKu <ku920601@realtek.com>,
        Bernie Huang <phhuang@realtek.com>,
        Shaofu <shaofu@realtek.com>,
        Steven Ting <steventing@realtek.com>,
        Kevin Yang <kevin_yang@realtek.com>
Subject: Re: [PATCH 6/7] rtw88: 8822c: add CFO tracking
References: <20210319054218.3319-7-pkshih@realtek.com>
        <20210411091951.2B01AC433CA@smtp.codeaurora.org>
        <6ea1eb17f2a64fd0954b9d4060da12f0@realtek.com>
Date:   Mon, 12 Apr 2021 14:47:49 +0300
In-Reply-To: <6ea1eb17f2a64fd0954b9d4060da12f0@realtek.com>
        (pkshih@realtek.com's message of "Mon, 12 Apr 2021 08:11:09 +0000")
Message-ID: <87mtu3lo62.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Pkshih <pkshih@realtek.com> writes:

>> -----Original Message-----
>> From: kvalo=codeaurora.org@mg.codeaurora.org
>> [mailto:kvalo=codeaurora.org@mg.codeaurora.org] On
>> Behalf Of Kalle Valo
>> Sent: Sunday, April 11, 2021 5:20 PM
>> To: Pkshih
>> Cc: tony0620emma@gmail.com; linux-wireless@vger.kernel.org; DeanKu;
>> Bernie Huang; Shaofu; Steven Ting;
>> Kevin Yang
>> Subject: Re: [PATCH 6/7] rtw88: 8822c: add CFO tracking
>> 
>> Ping-Ke Shih <pkshih@realtek.com> wrote:
>> 
>> > From: Po-Hao Huang <phhuang@realtek.com>
>> >
>> > Add CFO tracking mechanism to mitigate the effect of oscillator
>> > frequency discrepancy.
>> >
>> > Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>> 
>> What's CFO? I need to understand the commit log, so please write it so that any
>> engineer working with wireless understands it.
>> 
>
> CFO tracking, which stands for central frequency offset tracking, is used to
> adjust oscillator to align central frequency of connected AP. Then, we can
> have better performance.
>
> Should I resend this patch to explain CFO?

Yes, please send a new version with an updated commit log.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches