Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mt76: mt7921: remove 80+80 MHz support capabilities
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
References: <20210411104751.24103-1-nbd@nbd.name>
 <18627505ec45f8e5a0e424c3f3f9ca204cb1830c.camel@sipsolutions.net>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <3a8e0269-cf1b-e77f-086e-15c9c1e3a2aa@nbd.name>
Date:   Mon, 12 Apr 2021 16:35:25 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <18627505ec45f8e5a0e424c3f3f9ca204cb1830c.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2021-04-12 14:45, Johannes Berg wrote:
> On Sun, 2021-04-11 at 12:47 +0200, Felix Fietkau wrote:
>> This mode is not supported by the hardware
>> 
> You say this "mode" (singular), and the subject says "80+80",
> 
>> -		he_mcs->rx_mcs_160 = cpu_to_le16(mcs_map);
>> -		he_mcs->tx_mcs_160 = cpu_to_le16(mcs_map);
> 
> but you proceed to also remove 160, was that intentional?
Yes. 160 MHz isn't supported and no capability was set for it either.

- Felix