Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2441799pxb; Tue, 13 Apr 2021 01:48:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjuQoNzKRfRYLXLj9A7a5IUWjhlWwpQWqFPdst7RcHoqdHP9NMzN3r1CWPOMCZWRRhMTOz X-Received: by 2002:a17:902:ac98:b029:ea:b3c2:53da with SMTP id h24-20020a170902ac98b02900eab3c253damr18110737plr.23.1618303724613; Tue, 13 Apr 2021 01:48:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618303724; cv=none; d=google.com; s=arc-20160816; b=W96r/JAqmalV9oIrQ4p8LBWDClvvkI1gJjer84ptHxkQj/0Ar8YX0vi1usAEQ/lEvj 4YmEaftSB4p2/VnFoNG/FZdZStn/whddEa6qC9uKdJED+i4fs2o9T3XJzO6ufrZTZj8o udQRN2ehV8XYsY94XtaaB2YiiD2ye9xWc3GE+WcyWl7SI7wF0zVUaEmPJ4PWfSKTa2rl BV94sTCuJAKqJOvnoDxOh1D82qmYZFl99PyUJoc4L1cVFDcy4CvXle3s7N+arLLLjrdW 5jvkSggwpspp3o31/CltT71lyje9Fiu2EIs2rwhG6fzYtKCLMV26hpi/r2q+i25fsoHs QWNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=lZgJdwTeyriIOxHKpSHnk17RezJBJ3nlHFKcDpE45MQ=; b=Z3ElPiMCoaaoybjqPzyPlva2ivLsJSsBb6UmMTzpEE8VFO6fm6PONAl1ycaq2MUxAC 60tHr40if9cu5Ef9oSPB+W+3bLc9L2HYzw0uZlg4oXBWcsQM24Zb11e05bYyYjnCAwyU 8pp8lM8BEceeHoTu8Y+oG8HEDZaaFRfI0x3jrDufmZTmFIUzIg+1dytvAyXxH6o8tTDj f9rbfBbsG0N8t2fT4fWZaKSfpnrKFAtd97YDZ/BZW9Qs+u9erS/CwWPy0oNicHJxPpJU 5VkaM7PcmUG55Wfpzj4Ls629+LJdpP6IWACT4yT4x7kr5w997lgaR5OsJnaWjCNaB06w NBPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h2si17344044plr.210.2021.04.13.01.48.29; Tue, 13 Apr 2021 01:48:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244360AbhDMFfY (ORCPT + 99 others); Tue, 13 Apr 2021 01:35:24 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:48134 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229705AbhDMFfX (ORCPT ); Tue, 13 Apr 2021 01:35:23 -0400 X-UUID: 0c7a7f8a4ffa4d769d8f3137236e2614-20210413 X-UUID: 0c7a7f8a4ffa4d769d8f3137236e2614-20210413 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 191661973; Tue, 13 Apr 2021 13:35:00 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Apr 2021 13:34:58 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 13 Apr 2021 13:34:57 +0800 From: Ryder Lee To: Felix Fietkau , Lorenzo Bianconi CC: Shayne Chen , , , Ryder Lee Subject: [PATCH 1/2] mt76: mt7615: fix memleak when mt7615_unregister_device() Date: Tue, 13 Apr 2021 13:34:56 +0800 Message-ID: <519a81d0c36ab64750a39b1eac3cb86a09cb2f1d.1618290080.git.ryder.lee@mediatek.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: E5DB2D9EF93713D4D4B0D1043C6360E7C430CD89F08320BD661F2A4391AA6A952000:8 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org mt7615_tx_token_put() should get call before mt76_free_pending_txwi(). Fixes: a6275e934605 ("mt76: mt7615: reset token when mac_reset happens") Signed-off-by: Ryder Lee --- drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c b/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c index a629d9cb3806..a03484e34bb4 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c @@ -164,10 +164,9 @@ void mt7615_unregister_device(struct mt7615_dev *dev) mt76_unregister_device(&dev->mt76); if (mcu_running) mt7615_mcu_exit(dev); - mt7615_dma_cleanup(dev); mt7615_tx_token_put(dev); - + mt7615_dma_cleanup(dev); tasklet_disable(&dev->irq_tasklet); mt76_free_device(&dev->mt76); -- 2.18.0