Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2441815pxb; Tue, 13 Apr 2021 01:48:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgawk4DQEOZXkJbFc2qNZdnssOEUFsPYdNGLWHZWa09uO7apS5dhXKuMAgw3TexoF+3ZCe X-Received: by 2002:a17:902:db0c:b029:eb:36ed:3715 with SMTP id m12-20020a170902db0cb02900eb36ed3715mr765944plx.22.1618303728586; Tue, 13 Apr 2021 01:48:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618303728; cv=none; d=google.com; s=arc-20160816; b=r2XESul0n05L7/PGepWLy8Pshf9Ji+1JeM8tKAuBr77RiD1Vf0oIlNNPxWfoe0IMZe H5IqnQe8avO/dJAR0ZJF07OAPZQmz4bzqSPK4BW1b8+8/k7CVetz2ZbWg1ikNuxa/ZYz kDwjEyEsHdZXxHcuqCjKrLbfZwRL8Pc879NVNl3VcftpSnOx5LoL+agEAymMjHwczpA6 jwO7qjXNIWOFgf1ACeyUwW1XO984ZrhJyVTmRrX9q96M0fQEQlAlUDpuRfrIlxZ5PObb a7u0SgspM9F+YB7mWypdLltOKfgM6L2G23Cq6+7kq/fnoIsInPO0efFdRuagEmSj9YX2 uvyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=o/qj5JZmjjlXjUdj8F4gQComgcCNaBbICZ0RezjqGjw=; b=0pygfdWr40HC0nWN5tNKMemlAD7JRRaVIP4XJ4NSwaGSKBJbHZSA4RV5bnFL746VzR v9ImLXrAPK0SkJTQZcZliN/VyAuTQ6fE6Dwsw5JXbNVcsZtunE0W5b3ELHYHVIlAdUY+ GUPN7lGmDtWzo6D63H19QjdIf/08lu1mlQnPEjURjmkmoMhYWVjeXfjfjFdsxjwjVXRn 4QIXPRNso9vQ87I93/MP90qSW95pH1r0qnsp/pWfuUyn6AmLTVrkcl27asw0bJuyFJPz xOrvVIkdlTByhvzA3AbQsL8oVyJZP9UhfodQzdJnhkilDikXm4UqKKsEl4NozQHpPhRR MvSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si16363254plr.271.2021.04.13.01.48.35; Tue, 13 Apr 2021 01:48:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244467AbhDMFfZ (ORCPT + 99 others); Tue, 13 Apr 2021 01:35:25 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:48147 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S244195AbhDMFfY (ORCPT ); Tue, 13 Apr 2021 01:35:24 -0400 X-UUID: c8704437166a42389fffdcf3b9471e43-20210413 X-UUID: c8704437166a42389fffdcf3b9471e43-20210413 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1697646784; Tue, 13 Apr 2021 13:35:00 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Apr 2021 13:34:58 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 13 Apr 2021 13:34:58 +0800 From: Ryder Lee To: Felix Fietkau , Lorenzo Bianconi CC: Shayne Chen , , , Ryder Lee Subject: [PATCH 2/2] mt76: mt7915: fix memleak when mt7915_unregister_device() Date: Tue, 13 Apr 2021 13:34:57 +0800 Message-ID: <3bf5d5df8fcd20a8a093c2de849f527c28c6fc54.1618290080.git.ryder.lee@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <519a81d0c36ab64750a39b1eac3cb86a09cb2f1d.1618290080.git.ryder.lee@mediatek.com> References: <519a81d0c36ab64750a39b1eac3cb86a09cb2f1d.1618290080.git.ryder.lee@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: 1C05952F9C6A380AA889A5D17CC999E72F6B5A0625C5EB7C02979FA5D022D8B62000:8 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org mt7915_tx_token_put() should get call before mt76_free_pending_txwi(). Fixes: f285dfb98562 ("mt76: mt7915: reset token when mac_reset happens") Signed-off-by: Ryder Lee --- drivers/net/wireless/mediatek/mt76/mt7915/init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c index 3f9f74aa8399..6322a92fd2d0 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c @@ -744,9 +744,8 @@ void mt7915_unregister_device(struct mt7915_dev *dev) mt7915_unregister_ext_phy(dev); mt76_unregister_device(&dev->mt76); mt7915_mcu_exit(dev); - mt7915_dma_cleanup(dev); - mt7915_tx_token_put(dev); + mt7915_dma_cleanup(dev); mt76_free_device(&dev->mt76); } -- 2.18.0