Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Apr 2021 10:27:11 +0200
From:   Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     nbd@nbd.name, linux-wireless@vger.kernel.org,
        sean.wang@mediatek.com
Subject: Re: [PATCH] mt76: mt7921: get rid of mt7921_dma_cleanup
Message-ID: <YHVV3xtrPueZriNR@lore-desk>
References: <a685211cdac6d961744cbbc6c9af54c177023e95.1618301684.git.lorenzo@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="9fgPcQv0xKNGPojk"
Content-Disposition: inline
In-Reply-To: <a685211cdac6d961744cbbc6c9af54c177023e95.1618301684.git.lorenzo@kernel.org>
Precedence: bulk


--9fgPcQv0xKNGPojk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Remove mt7921_dma_cleanup routine since it is no longer used
>=20
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
>  .../net/wireless/mediatek/mt76/mt7921/dma.c   | 23 -------------------
>  .../wireless/mediatek/mt76/mt7921/mt7921.h    |  1 -
>  2 files changed, 24 deletions(-)

Hi Felix,

please ignore this patch, we need mt7921_dma_cleanup unloading the module.

Regards,
Lorenzo

>=20
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c b/drivers/ne=
t/wireless/mediatek/mt76/mt7921/dma.c
> index 992faf82ad09..14e694563a89 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> @@ -331,26 +331,3 @@ int mt7921_dma_init(struct mt7921_dev *dev)
> =20
>  	return 0;
>  }
> -
> -void mt7921_dma_cleanup(struct mt7921_dev *dev)
> -{
> -	/* disable */
> -	mt76_clear(dev, MT_WFDMA0_GLO_CFG,
> -		   MT_WFDMA0_GLO_CFG_TX_DMA_EN |
> -		   MT_WFDMA0_GLO_CFG_RX_DMA_EN |
> -		   MT_WFDMA0_GLO_CFG_CSR_DISP_BASE_PTR_CHAIN_EN |
> -		   MT_WFDMA0_GLO_CFG_OMIT_TX_INFO |
> -		   MT_WFDMA0_GLO_CFG_OMIT_RX_INFO |
> -		   MT_WFDMA0_GLO_CFG_OMIT_RX_INFO_PFET2);
> -
> -	/* reset */
> -	mt76_clear(dev, MT_WFDMA0_RST,
> -		   MT_WFDMA0_RST_DMASHDL_ALL_RST |
> -		   MT_WFDMA0_RST_LOGIC_RST);
> -
> -	mt76_set(dev, MT_WFDMA0_RST,
> -		 MT_WFDMA0_RST_DMASHDL_ALL_RST |
> -		 MT_WFDMA0_RST_LOGIC_RST);
> -
> -	mt76_dma_cleanup(&dev->mt76);
> -}
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h b/drivers=
/net/wireless/mediatek/mt76/mt7921/mt7921.h
> index e3d83d3d954c..1e70c749bbf3 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> @@ -225,7 +225,6 @@ int mt7921_eeprom_get_target_power(struct mt7921_dev =
*dev,
>  void mt7921_eeprom_init_sku(struct mt7921_dev *dev);
>  int mt7921_dma_init(struct mt7921_dev *dev);
>  void mt7921_dma_prefetch(struct mt7921_dev *dev);
> -void mt7921_dma_cleanup(struct mt7921_dev *dev);
>  int mt7921_run_firmware(struct mt7921_dev *dev);
>  int mt7921_mcu_init(struct mt7921_dev *dev);
>  int mt7921_mcu_add_bss_info(struct mt7921_phy *phy,
> --=20
> 2.30.2
>=20

--9fgPcQv0xKNGPojk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYHVV3AAKCRA6cBh0uS2t
rJTfAP9uYJMI8I6VGzw0zM7kMTy1zgiqjXeYqF6yCVmOlKowKwEAvFcUOIUVlQF8
s+0CBgmcw+9BK6mKCeiK4X+YGVw2FwA=
=2EOY
-----END PGP SIGNATURE-----

--9fgPcQv0xKNGPojk--