Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2475627pxb;
        Tue, 13 Apr 2021 02:53:17 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJz250E1pH7LmkoWn3TsZRxzM+7ZEPS529G+2/wU2UbCgfKdtl2bHRVauywAekGn0+zTRj9n
X-Received: by 2002:a17:90a:bb86:: with SMTP id v6mr4024262pjr.37.1618307596894;
        Tue, 13 Apr 2021 02:53:16 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1618307596; cv=none;
        d=google.com; s=arc-20160816;
        b=ozsIqpdLHRPaZKNkvu8FgO5CPod//mJPhbDLvXmg6aVYBjKWSD77tg0lFAk71yMHJK
         2Ez+N2JZ/vKVZM5fPhAIm51prjQDPzRF5C0PQKmiQSe2YMPVIS1MbwFtxWGRx9Rsu8Bl
         Y1Q/bXmqyhPfZQa/UY3y2t+JOOvlcpV321vvARIkehC/23sdaa37ACUidwfI+QtlEY1c
         AyjVTSUsBD7X7gyvHO8reg3UzxhEU19i6+zn/Qk66InPZqaeVC3klXCEaBFICztmlzSp
         N8HAO56aTeY6cg+ScsbnUIR41TCFroP9Jt/8ioTbtNBqyYIPw7hT09tEUcvO+s1OhUrk
         kkxQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:content-language
         :in-reply-to:mime-version:user-agent:date:message-id:from:references
         :cc:to:subject:dkim-signature;
        bh=OtgCHsWYPlJuex0DZzLsQBEBTnQ/M9pwex4ouMB0c4U=;
        b=KOt8Wb9fB+0lz3hQEn9r9yEguHVhUNi27904SqmXbbbEHEQLoMKUZbFMwgL3roDsyH
         v/NDM5CNJQZRRaisJLYbbBkw7iOZdPY8u+cclCUxZLWdgtVoQVIocp6KTLLOj1lbcVEN
         cOsd+WYHkzKw+329uvHuYBQZCxZu60WoIweD51TiMpen9p/+IuDKTKcK8bP/fjvM26sF
         2LSn3szStXfhrc59ezjDlng0zqYkYcM3OIByqsa4CPRQ/zmRBOPt4N47C/szZntMHgwT
         yk0j6jb+PkXuTpgSx+qhP4zGdgtdVbdto1tOFUPSJNZY8BsOHuSYGn8s+WLs36njP/Sg
         RBjA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@nbd.name header.s=20160729 header.b=nabzFeHM;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org
Return-Path: <linux-wireless-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id d18si13538449plg.180.2021.04.13.02.53.03;
        Tue, 13 Apr 2021 02:53:16 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@nbd.name header.s=20160729 header.b=nabzFeHM;
       spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238218AbhDMJ1Z (ORCPT <rfc822;benjamin.aschenbrenner@gmail.com>
        + 99 others); Tue, 13 Apr 2021 05:27:25 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48842 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230209AbhDMJ1Y (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 13 Apr 2021 05:27:24 -0400
Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E22EC061574
        for <linux-wireless@vger.kernel.org>; Tue, 13 Apr 2021 02:27:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name;
         s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:
        MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:
        Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
        Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
        List-Subscribe:List-Post:List-Owner:List-Archive;
        bh=OtgCHsWYPlJuex0DZzLsQBEBTnQ/M9pwex4ouMB0c4U=; b=nabzFeHMoowN+GY2yxjsIMn+xo
        22EidAR3XgUrpAl0R9r9jpStv0fZ2Zbor1X8/4a5AwRdqTz4Agy6SEg8CUcloewE4RblPt37l54bq
        6YrgWThNIM3Va+5fhN/SVL+qzJ2xIAmMK9FnV8gAck5S0WnCh1X0Fg9G02lovHoMRx5E=;
Received: from p4ff13c8d.dip0.t-ipconnect.de ([79.241.60.141] helo=nf.local)
        by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
        (Exim 4.89)
        (envelope-from <nbd@nbd.name>)
        id 1lWFJw-0003SL-PW; Tue, 13 Apr 2021 11:26:56 +0200
Subject: Re: [PATCH] mt76: mt7921: add mt7921_dma_cleanup in
 mt7921_unregister_device
To:     Lorenzo Bianconi <lorenzo@kernel.org>
Cc:     linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
        sean.wang@mediatek.com
References: <e78ac49fa2e22c034b934f4ee433b5476e22706c.1618302972.git.lorenzo@kernel.org>
From:   Felix Fietkau <nbd@nbd.name>
Message-ID: <9041dd42-8bc8-621c-171e-ef3efbde86bc@nbd.name>
Date:   Tue, 13 Apr 2021 11:26:55 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <e78ac49fa2e22c034b934f4ee433b5476e22706c.1618302972.git.lorenzo@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


On 2021-04-13 10:40, Lorenzo Bianconi wrote:
> In order to avoid memory leaks, clean the dma engine unloading the
> module
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Now it is accessing DMA registers after mt7921_mcu_exit has already
called mt7921_wfsys_reset.
Please move the mt7921_mcu_exit call further down.

- Felix