Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2689423pxb; Tue, 13 Apr 2021 07:57:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhGnoWUuAH4Z8tQkC1fskhSXIeWCi0WSl3qOjS8JT0ih8pcHRXNbXmKh4YjXBWfnDGfZZd X-Received: by 2002:a17:906:729d:: with SMTP id b29mr25326955ejl.461.1618325836245; Tue, 13 Apr 2021 07:57:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618325836; cv=none; d=google.com; s=arc-20160816; b=yLT4ijU9Zd+9TSpLsc4i1gctwct7nPj+LzEOnNLTfU4vO2v7MmMhbod4tVF3M3RVPv yAb1VcAzWA+Ivpw3+XSaJATcW7HVXz5yJo8TuLaM9owJLupffnlUoYwiQbq46iD8jiyH rxYqRRAx+C1ZVKocBOONn3F0QNaP0HuymWOj+kZcetB1dq4VZaIC1F69ZPsLqnQ1K9qW v74nqvPXG0h+4J7a7jWO3oEhwokNkFz1YN4ptf4pkwskTpWWlQc+11HQJmCPFr8TkNJc ThrRxl8FsWwQM1QJbuudSbQsQ5OdOunRsDm7t0QGWu0joVMqUWhjWyO7wZKm5YATcq7o tYNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/7LB/ACQmIYk2nZFPGy/x6lqqPYNH5EVZjyhQvK9fM8=; b=sHmGt6REBfLEQ4l5qQ7QDfBmohDJvhlVKGFd0IyemrCrHNLKSqsdKTm7fK33hGUGSq YAAYW8dvjtkRJmj5NoIszfbfdxJ8uDhJWjGGXyNOofFDrHv1RYivyDEI6TJaI9mfMnbL WWDqK1BGA1S+AbnN/s4BLbdeT5U6WEOtsk2wDhh5HRlthz55QZZgRaHtaQm9kPzeGhEy 9GJbYb4kPa7PrCuo/D2F7ZYSFCfiVErL4XCQO9IQ3q0JVZ5l46/GlAIMLjJS/VYHY1tZ 5HK3ORzcRZaMvA2sOPkuhxS2bTLMlDr4SZIhFIRialWYr0y4F9qUX4SeOs+UtAPQTVTm xVLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ggzUE4ma; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ec23si10502261ejb.710.2021.04.13.07.56.52; Tue, 13 Apr 2021 07:57:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ggzUE4ma; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238459AbhDMMOT (ORCPT + 99 others); Tue, 13 Apr 2021 08:14:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:43918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbhDMMOS (ORCPT ); Tue, 13 Apr 2021 08:14:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DFC1600D4; Tue, 13 Apr 2021 12:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618316039; bh=El0x2wWUEywg8Sq6LyhSCyV3rEE56ojTe4fLgQfoeH8=; h=From:To:Cc:Subject:Date:From; b=ggzUE4mazp4/58s+eE0kFJLVNHBEHHkKmV3l9RdebjIloXbOwBwIDWrnOdnMbNZTX Ov51RER4HqAUS7zIoLQYtHyUmhlh7jptVpMl8TpxQjveq8IPhmUtP3P6dxY6UPASEA bfOZML1Ug7e+7WTYAErhrCg4IIVfkDJLgoCxbZCUhSSu8K49fe6S3qkom03j2K/OBb wBwBGjdcmdxyUfhBuzYOs8aQT+h3uGR3ajMmoiBNWMrFVPDnDTYC8G+jzyQK8WQuy+ FKr7myJTAIN97MbndTZsodXfaClWiXPyD6Pu8KP02RTStFNub9Ct6ZbikQRXKWaHVs bhYri+ro3TnKw== From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, sean.wang@mediatek.com Subject: [PATCH v2] mt76: mt7921: add mt7921_dma_cleanup in mt7921_unregister_device Date: Tue, 13 Apr 2021 14:13:54 +0200 Message-Id: <63d4a09e87c5ced03fc27aa1aa85a85144716ebf.1618315935.git.lorenzo@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org In order to avoid memory leaks, clean the dma engine unloading the module Signed-off-by: Lorenzo Bianconi --- Changes since v1: - move mt7921_dma_cleanup before mt7921_mcu_exit --- drivers/net/wireless/mediatek/mt76/mt7921/init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c index 5bb0a7b9e9e5..94fe2eadf285 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c @@ -272,8 +272,9 @@ int mt7921_register_device(struct mt7921_dev *dev) void mt7921_unregister_device(struct mt7921_dev *dev) { mt76_unregister_device(&dev->mt76); - mt7921_mcu_exit(dev); mt7921_tx_token_put(dev); + mt7921_dma_cleanup(dev); + mt7921_mcu_exit(dev); tasklet_disable(&dev->irq_tasklet); mt76_free_device(&dev->mt76); -- 2.30.2