Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <e9e7425cf7bbbf20f0dac74e222d28f747216804.camel@redhat.com>
Subject: Re: "rfkill: add a reason to the HW rfkill state" breaks userspace
From:   Benjamin Berg <bberg@redhat.com>
To:     Hans de Goede <hdegoede@redhat.com>,
        Johannes Berg <johannes@sipsolutions.net>,
        "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Wed, 14 Apr 2021 12:46:07 +0200
In-Reply-To: <b3273466-7978-241f-9773-56cd87490a9b@redhat.com>
References: <efafa85c-c021-14ff-619c-fdd0db53ddbb@redhat.com>
         <SA0PR11MB4752FEE472EC18B6A4F376FAF24E9@SA0PR11MB4752.namprd11.prod.outlook.com>
         <2db76f5161be090f9fec2bc4fcb8973533e32564.camel@sipsolutions.net>
         <e06b4ca8-6f1f-1c49-5454-b96af9fdd7df@redhat.com>
         <bb6eece123644f32e861456f9aa1056a9db78066.camel@redhat.com>
         <b3273466-7978-241f-9773-56cd87490a9b@redhat.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-/f/SYqvIY9aNtepX36bE"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Precedence: bulk


--=-/f/SYqvIY9aNtepX36bE
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, 2021-04-14 at 12:29 +0200, Hans de Goede wrote:
> On 4/14/21 11:52 AM, Benjamin Berg wrote:
> > [SNIP]
> >=20
> > That said, the g-s-d event handler is checking the size of the read
> > against the struct size. This is obviously wrong, it should only
> > check
> > that the read was successful (or check for >=3D V1 size).
>=20
> Right this is what I was referring to a g-s-d compiled against the
> new headers with a struct size of 9 will read 8 bytes on an old
> kernel
> and that will fail the len check, so it won't work.
>=20
> But this will actually never happen as I just noticed that g-s-d
> uses a private rfkill.h copy with the old 8 bytes struct definition.
>=20
> So with the buffered-io disabled everything should work fine,
> see my other email in this thread.

OK, so at least that part of the fix should be backported to older
release branches.

> We should probably still fix / clean the code a bit though, as
> you are working on in:
>  =20
> https://gitlab.gnome.org/GNOME/gnome-settings-daemon/-/merge_requests/234

Yeah, the code there is somewhat messy overall. It could probably be
improved more than the MR does, but hopefully at least the biggest
inconsistencies are gone now.

Benjamin

--=-/f/SYqvIY9aNtepX36bE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEED2NO4vMS33W8E4AFq6ZWhpmFY3AFAmB2x+8ACgkQq6ZWhpmF
Y3BMyRAA2GbVGUiyG1mAn3Uzu/Wp79FAlGhu7q7QFUumi3OEHWoyz+NnYnWCur7r
1tc2U0ZD9wYUA33NPpH6wDxD5Hh09MX0nYyuYLLnguY9IC93bNAzflvthyQUbQG6
ZKQg8JBvH+LzV/RTcMUF81c7Zu41BecAeW7N4mXP/T76DkzS4m6zGQ+Lk6XuebxW
ESaHnsz7IPcdkCBFHfyJbjRRciPaLemCZi9CPO2jYC6FjB/5QFQnSrBVk6RJLGom
NUC54+a03QvlHnksl/YtHEH8ZJ54PaInxnZhy7Kqpz9C0FNp0iIhMPH84tqstz2H
CPCQm2UdZFwVURPpdmCgzDJiLa4wOVSPaHrYSpo+858DHVVzX8wgQL7vhUEGcTJ5
Rpt1uS7eSrvcRr55PtivQD+CgMID4E6/n96lzvmqOz5MFF8nI3JECsngpTq3yfT2
dj2udgGDmGMBQOxQiloMYHL8zQP3qUfZDBV3IRqpkYAj2sZLkO5whYpUhr3G2olq
jAP9kcYapj8IXvMIrb7jl9HNj5hEkZ5fxLIAABpCt5buV+YNFV8ynJft3na6IPHn
rBzM262Zy1B7SqwbD9CXQQHOpl0yOt3SuE/MeFrOHPFeWbjSQfHvua4Ogq+8JN2u
40HCz3LVDoEbFPt30oPyWCH1fSrguybhIDib0YHGJv9F8EYAdhE=
=HHBN
-----END PGP SIGNATURE-----

--=-/f/SYqvIY9aNtepX36bE--