Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <YHaoA1i+8uT4ir4h@mwanda>
In-Reply-To: <YHaoA1i+8uT4ir4h@mwanda>
From:   Stanislav Yakovlev <stas.yakovlev@gmail.com>
Date:   Wed, 14 Apr 2021 15:09:59 +0400
Message-ID: <CA++WF2M_XOPhUpARSi8+-JfcmF2rfY8jM5+j7vTuA5YFsYbqiw@mail.gmail.com>
Subject: Re: [PATCH v2] ipw2x00: potential buffer overflow in libipw_wx_set_encodeext()
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        James Ketrenos <jketreno@linux.intel.com>,
        Jeff Garzik <jgarzik@pobox.com>,
        wireless <linux-wireless@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 14 Apr 2021 at 12:30, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The "ext->key_len" is a u16 that comes from the user.  If it's over
> SCM_KEY_LEN (32) that could lead to memory corruption.
>
> Fixes: e0d369d1d969 ("[PATCH] ieee82011: Added WE-18 support to default wireless extension handler")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: use clamp_val() instead of min_t()
>
>  drivers/net/wireless/intel/ipw2x00/libipw_wx.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>

Cc: stable@vger.kernel.org
Acked-by: Stanislav Yakovlev <stas.yakovlev@gmail.com>

Stanislav.