Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bab37babea4f2972ef222e1dcaff7ab966ab15a8.camel@coelho.fi>
From:   Luca Coelho <luca@coelho.fi>
To:     kvalo@codeaurora.org
Cc:     jikos@kernel.org, hdegoede@redhat.com, johannes@sipsolutions.net,
        linux-wireless@vger.kernel.org
Date:   Thu, 15 Apr 2021 16:52:35 +0300
In-Reply-To: <iwlwifi.20210415164821.d0f2edda1651.I75f762e0bed38914d1300ea198b86dd449b4b206@changeid>
References: <iwlwifi.20210415164821.d0f2edda1651.I75f762e0bed38914d1300ea198b86dd449b4b206@changeid>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH for -next] iwlwifi: pcie: don't enable BHs with IRQs
 disabled
Precedence: bulk

On Thu, 2021-04-15 at 16:48 +0300, Luca Coelho wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> After the fix from Jiri that disabled local IRQs instead of
> just BHs (necessary to fix an issue with submitting a command
> with IRQs already disabled), there was still a situation in
> which we could deep in there enable BHs, if the device config
> sets the apmg_wake_up_wa configuration, which is true on all
> 7000 series devices.
> 
> To fix that, but not require reverting commit 1ed08f6fb5ae
> ("iwlwifi: remove flags argument for nic_access"), split up
> nic access into a version with BH manipulation to use most
> of the time, and without it for this specific case where the
> local IRQs are already disabled.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---

Kalle, I'm going to assign this one to you too, but this time for -next
and not for -fixes.

This is related to the fix Jiri made, but to avoid some conflicts and a
broken v5.13-rc, we want to get it into v5.13 if still possible.

So can you please take this on top of my latest pull request?
Additionally, can you tag it for stable?

Thanks!

--
Cheers,
Luca.