Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <9fafe866-6ff6-d1c4-0a04-493d863bc9db@redhat.com>
 <CAJCQCtRFqmioneenXeNEoBXnjGCrOeU-SthZKT60bQoMD84K2w@mail.gmail.com> <10faeb84-1232-f179-a687-35a148fb7a0d@redhat.com>
In-Reply-To: <10faeb84-1232-f179-a687-35a148fb7a0d@redhat.com>
From:   Chris Murphy <lists@colorremedies.com>
Date:   Thu, 15 Apr 2021 10:31:12 -0600
Message-ID: <CAJCQCtQosH3Pc2O4yc7n8eTdAcF=7AiJYxh+y1tuEE2kxMGfrg@mail.gmail.com>
Subject: Re: iwlwifi Lockdep warning with 5.12-rc4 on 8086:02f0 (Comet Lake
 PCH-LP CNVi WiFi)
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Chris Murphy <lists@colorremedies.com>,
        Luca Coelho <luciano.coelho@intel.com>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Apr 15, 2021 at 6:04 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi Chris,
>
> On 4/13/21 11:38 PM, Chris Murphy wrote:

> > Looks like this:
> > https://lore.kernel.org/linux-wireless/nycvar.YFH.7.76.2103021125430.12405@cbobk.fhfr.pm/
> >
> > I tested that patch on rc6 and it worked so far.
>
> That patch has been added to rc7, so I tested rc7 and rc7 still has the lockdep splat in dmesg.

I'm running 5.12.0-0.rc7.189.fc35.x86_64+debug and don't have the lockdep splat.

[   12.502108] iwlwifi 0000:6c:00.0: Detected Intel(R) Dual Band
Wireless AC 8260, REV=0x204

> But good news, the issue is my wifi card uses iwl_pcie_gen2_enqueue_hcmd where as the
> patch you linked to fixes iwl_pcie_enqueue_hcmd . Applying the same changes to the
> iwl_pcie_gen2_enqueue_hcmd function also fixes lockdep complaining for me.

OK super.


-- 
Chris Murphy