Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@redhat.com>
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless@vger.kernel.org
Cc:     Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: properly process TXQ management frames
In-Reply-To: <20210416134702.ef8486a64293.If0a9025b39c71bb91b11dd6ac45547aba682df34@changeid>
References: <20210416134702.ef8486a64293.If0a9025b39c71bb91b11dd6ac45547aba682df34@changeid>
Date:   Fri, 16 Apr 2021 14:49:40 +0200
Message-ID: <87sg3qgzrv.fsf@toke.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Johannes Berg <johannes@sipsolutions.net> writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> My previous commit to not apply flow control to management frames
> that are going over TXQs (which is currently only the case for
> iwlwifi, I think) broke things, with iwlwifi firmware crashing on
> certain frames. As it turns out, that was due to the frame being
> too short: space for the MIC wasn't added at the end of encrypted
> management frames.
>
> Clearly, this is due to using the 'frags' queue - this is meant
> only for frames that have already been processed for TX, and the
> code in ieee80211_tx_dequeue() just returns them. This caused all
> management frames to now not get any TX processing.
>
> To fix this, use IEEE80211_TX_INTCFL_NEED_TXPROCESSING (which is
> currently used only in other circumstances) to indicate that the
> frames need processing, and clear it immediately after so that,
> at least in theory, MMPDUs can be fragmented.
>
> Fixes: 73bc9e0af594 ("mac80211: don't apply flow control on management fr=
ames")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@redhat.com>