Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1230538pxb; Sat, 17 Apr 2021 10:33:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUJwMCKwC10Di5CxK/DoEW8gv3roU8AnElV37EsJHS3XSNbErtVFquzvgAbehHCW6ynY00 X-Received: by 2002:a17:906:77c5:: with SMTP id m5mr13265254ejn.201.1618680809466; Sat, 17 Apr 2021 10:33:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618680809; cv=none; d=google.com; s=arc-20160816; b=EvvSpyjwY1OTc9sQny5bGLDsjWF75sbm1iP/YKt0Lt6kMKtqe2J1OK+u10nwt69Fhi RHmWKB/IZPs9+S76dIdWzwC0MYc/m4LVw9wdA5D4lryife+w6LykyjUaFy2mX4GjbemI Fbz7xlNNepwGKTJ0w8pR9tGC8I/ftWY1514xylGOdtecH5bngPl6NGDdYlI9c9DrQRir MYXGTnyn4jamG4dGgJKcwofYREKXXbL59eo1jzwDrEntjzTg8iO2yO8pq27ZU8Xe3ebN y1VFeGog3mrwN66LrauNSAbprZcH2iw79dLkU53XcZIkL+cjp/QEGH0gjt9YXIat+FLg 8KAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=oGrf2roQmxF4YZup5JAhUH7H7oFrBregMKDCLyj2334=; b=vQ+mC7SZ2TQTFeNndt9y03U+xs+31JL5FLJe9061LySrwPJeHXOA0azJRiPl0ZTnXf EC7c5PGzF+29wBooqnkZruCrIFi5gfzzWAZeWp/btTB+ocfXTO3giJ0vd3RgYkYQ3/6J eB4L77u5NQ8+Yl8m7hx35MyBv0LfBSSpv09IGTLFfIBcajuzC0JIExy5y+gW7OSTz2D7 pqLI2tijDDwCQ51Y0LsRfEVGS/7Zodv81XKXU9U3Py4L9nH+NoVRzXDSb6AeYvmDss5H 3tTmjMKvcnTPans7u5JYgtg5VI60yPHEbK7webncheT4HQP2fo3o15fvmao3axovlUNa GveQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=dDcm2hAj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k3si7382648ejk.569.2021.04.17.10.33.07; Sat, 17 Apr 2021 10:33:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=dDcm2hAj; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236698AbhDQRdb (ORCPT + 99 others); Sat, 17 Apr 2021 13:33:31 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:31556 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236620AbhDQRda (ORCPT ); Sat, 17 Apr 2021 13:33:30 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618680784; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=oGrf2roQmxF4YZup5JAhUH7H7oFrBregMKDCLyj2334=; b=dDcm2hAjxausEVoMEY5mjK0/gsV4joJ/kaw3FJwyKyf1OVp8o50sdPuFSzs4zdf/JYF4CWF5 1+w50yi4zwr2fqR+bND7i9b66ydCe1djSTW/3gfYmSifAqli1Z0AK/blklAXTzDZr6cF1cAH PoBLrTbVBMVy8jdUiNYexVrwlLE= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 607b1bcff34440a9d420ce53 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 17 Apr 2021 17:33:03 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0AAF6C43217; Sat, 17 Apr 2021 17:33:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5F315C433F1; Sat, 17 Apr 2021 17:33:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5F315C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: Simplify locking of a skb list accesses From: Kalle Valo In-Reply-To: <99cf8894fd52202cb7ce2ec6e3200eef400bc071.1617609346.git.christophe.jaillet@wanadoo.fr> References: <99cf8894fd52202cb7ce2ec6e3200eef400bc071.1617609346.git.christophe.jaillet@wanadoo.fr> To: Christophe JAILLET Cc: pkshih@realtek.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210417173303.0AAF6C43217@smtp.codeaurora.org> Date: Sat, 17 Apr 2021 17:33:03 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Christophe JAILLET wrote: > The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail() > and __skb_dequeue() calls. > Use the lock provided in the skb itself and call skb_queue_tail() and > skb_dequeue(). These functions already include the correct locking. > > Signed-off-by: Christophe JAILLET > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. 1186006adee9 rtlwifi: Simplify locking of a skb list accesses -- https://patchwork.kernel.org/project/linux-wireless/patch/99cf8894fd52202cb7ce2ec6e3200eef400bc071.1617609346.git.christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches