Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: kvalo=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 43413C433D3
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] mwifiex: don't print SSID to logs
From:   Kalle Valo <kvalo@codeaurora.org>
In-Reply-To: <20210225024454.4106485-1-briannorris@chromium.org>
References: <20210225024454.4106485-1-briannorris@chromium.org>
To:     Brian Norris <briannorris@chromium.org>
Cc:     linux-wireless@vger.kernel.org, <linux-kernel@vger.kernel.org>,
        Ganapathi Bhat <ganapathi017@gmail.com>,
        Sharvari Harisangam <sharvari.harisangam@nxp.com>,
        Amitkumar Karwar <amitkarwar@gmail.com>,
        Xinming Hu <huxinming820@gmail.com>,
        Brian Norris <briannorris@chromium.org>
User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2
Message-Id: <20210417174706.DF190C43217@smtp.codeaurora.org>
Date:   Sat, 17 Apr 2021 17:47:06 +0000 (UTC)
Precedence: bulk

Brian Norris <briannorris@chromium.org> wrote:

> There are a few reasons not to dump SSIDs as-is in kernel logs:
> 
> 1) they're not guaranteed to be any particular text encoding (UTF-8,
>    ASCII, ...) in general
> 2) it's somewhat redundant; the BSSID should be enough to uniquely
>    identify the AP/STA to which we're connecting
> 3) BSSIDs have an easily-recognized format, whereas SSIDs do not (they
>    are free-form)
> 4) other common drivers (e.g., everything based on mac80211) get along
>    just fine by only including BSSIDs when logging state transitions
> 
> Additional notes on reason #3: this is important for the
> privacy-conscious, especially when providing tools that convey
> kernel logs on behalf of a user -- e.g., when reporting bugs. So for
> example, it's easy to automatically filter logs for MAC addresses, but
> it's much harder to filter SSIDs out of unstructured text.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Patch applied to wireless-drivers-next.git, thanks.

d23a96220353 mwifiex: don't print SSID to logs

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210225024454.4106485-1-briannorris@chromium.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches