Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1237295pxb; Sat, 17 Apr 2021 10:49:36 -0700 (PDT) X-Received: by 2002:a05:6a00:22d6:b029:247:9c54:de70 with SMTP id f22-20020a056a0022d6b02902479c54de70mr12990429pfj.1.1618681775824; Sat, 17 Apr 2021 10:49:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3fpc5QGAuhhLqaft4MtVO4J4gQYXNC6YMxjcM13DdKyGigyo7Xl0qHj6MMi89RVU/4rbu X-Received: by 2002:a05:6a00:22d6:b029:247:9c54:de70 with SMTP id f22-20020a056a0022d6b02902479c54de70mr12990399pfj.1.1618681775144; Sat, 17 Apr 2021 10:49:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618681775; cv=none; d=google.com; s=arc-20160816; b=abn6JlqrfCzRSZySsPW15KDU2WKVRW4qZKZKEfOlYzg6nSa7mKPiqU0nY5Hz8ZmOTE Heg08TlK5QEmLm/8D1szh5zvXL5fLpUGun2bz4OS/XPIVO/+iAvJziPIMqNTNtCs2Nsd TeO3cvs4+oBQSeOzp3N6qVgSu3elUOoOHhy7ET2/NJEkUK7reBvGRTO6ssR1HYRX5liR 9wxNVQeimkWOR5xfjKdcZ2w2i9zxd5X1MovT0G2VknocMSWHR72GbNDZQi+CcJC2j2ZX DSQcndb69NxYLi9pukZhf0DhRvdw/1IA9mxLi6U3FB6mn9mBMqyE9nRgUFv5whfwW1N+ Wrug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=ccsK5pmy+NKu+zryqAu1pvu8d0fsb8w75hriVHJX0XI=; b=t0Dp9L5MJd/hyMFBFkdUFaHdWyg3lnz2GBEaO5UKKjsLBs4IETvnexCm41KdySOCHt BjmQM69YQVaEl+10ESVcv/WdwSeLaBIbu5ZxHXRcrgN5W/SAO6SKjp18sPXvT8BivBio 4RHG9/mHSMBxMtGA94Qhh4vqL7LV5rOgtBov3rjdbcrb3f9BsifC8GBR7zDyFsLYLSxl aaFFNsb7PwSwhsLVYVhDpXFYifu4KbHiNqLD/NjXz52/uo6+7uSK1kUS1TX1vytjLvjp 3M1xX0r4KgpAbvEDwF3mAlqapmwHQOKHA4H7aIhNynsswrtVOqt1q1u9YoJjY9+/YxSZ TuCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=piwVqyLM; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si10715988pjh.5.2021.04.17.10.49.22; Sat, 17 Apr 2021 10:49:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=piwVqyLM; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236790AbhDQRtW (ORCPT + 99 others); Sat, 17 Apr 2021 13:49:22 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:14301 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236643AbhDQRtW (ORCPT ); Sat, 17 Apr 2021 13:49:22 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618681736; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=ccsK5pmy+NKu+zryqAu1pvu8d0fsb8w75hriVHJX0XI=; b=piwVqyLMltDiivTJcVQg6qj63KeREGK97Cb8lvVyttdHrB0ZGnN843SlXFHvdSjfuDYylMWr B8nBI5can73gxao6abzLXIdYBamJW/gJPZPz1B31STZhj3Qn396rN56IBO/qcxEgg1KqG02t 7YRk6FMdleD/MKwokhjFsw59Jpk= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 607b1f87a817abd39a273e9f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 17 Apr 2021 17:48:55 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 860D2C433D3; Sat, 17 Apr 2021 17:48:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C3CEEC433F1; Sat, 17 Apr 2021 17:48:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C3CEEC433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2 1/4] wilc1000: Make SPI transfers work at 48MHz From: Kalle Valo In-Reply-To: <20210227172818.1711071-1-davidm@egauge.net> References: <20210227172818.1711071-1-davidm@egauge.net> To: David Mosberger-Tang Cc: linux-wireless@vger.kernel.org, Ajay Singh , Claudiu Beznea , davidm@egauge.net User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210417174854.860D2C433D3@smtp.codeaurora.org> Date: Sat, 17 Apr 2021 17:48:54 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org David Mosberger-Tang wrote: > For CMD_SINGLE_READ and CMD_INTERNAL_READ, WILC may insert one or more > zero bytes between the command response and the DATA Start tag (0xf3). > This behavior appears to be undocumented in "ATWILC1000 USER GUIDE" > (https://tinyurl.com/4hhshdts) but we have observed 1-4 zero bytes > when the SPI bus operates at 48MHz and none when it operates at 1MHz. > > This code is derived from the equivalent code of the wilc driver in > the linux-at91 repository. > > Signed-off-by: David Mosberger-Tang 4 patches applied to wireless-drivers-next.git, thanks. f2131fa516b8 wilc1000: Make SPI transfers work at 48MHz 5ee2d9dd73fc wilc1000: Introduce symbolic names for SPI protocol register ce3b933832b6 wilc1000: Check for errors at end of DMA write c872e7ae056f wilc1000: Add support for enabling CRC -- https://patchwork.kernel.org/project/linux-wireless/patch/20210227172818.1711071-1-davidm@egauge.net/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches