Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1239843pxb; Sat, 17 Apr 2021 10:55:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3fHatfLEYy+mix+LhdBuWinUdmZH3AyGheyMginIOBxWhz0BM9QfhrFFwnMZBIjH3PMpo X-Received: by 2002:a63:6d04:: with SMTP id i4mr4254247pgc.97.1618682115036; Sat, 17 Apr 2021 10:55:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618682115; cv=none; d=google.com; s=arc-20160816; b=L+n3g4GviA06S5zij2FEYT/kPiTW+NKnQ9vetXeplu1Bgzrjh05DGgk8YMuXsJ1e9C keHSkcmeTel2mWufxQxUAnOwPQAa17yUag6sLP1vxQ6Xe5JDq2KRPZNUhEKcQ2+TawLi /WhWEBIRBRePDtVFM3NEHi0Xu1BMMrp5mFJEFvyU8xrGjt87OlUfSssRlA++xlHWmTqJ MaacMh5PgYdjp8ObR9VrAt1t3kBTIYYglqzlpTKoOgxTk+HRE3Zjn6sOkYySzBbY8n4d 6rlsKkTSny1AhwwcsTLmOT3DWZ9Zm8k7R82jDwK3FA2zFYTAC27VWdx1mPQlCKQNpOnk Iedg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=//tt+92mj+eYFVIm05nfExvtVOpazpB/GHsyCOcGeeg=; b=GLyC2idI/lQthu4SwRSM2dLTUKsmlaFYPwXikP1tTeZcycd8Rayt8NgbMfwKRrJJUg rn5QIRQfoGclRQhM9y//Ns+pSyt0a1i+K9RtUTXPjWa27DN3HMIDAsp1WfAZ2uGb0TbV 4KiNUElPOByzMPbf7caER1aWdmqlyEcJEjpx/MmduJXIGdrkXsGXkPccqAJn9jNao4Vu d9Oe1rfSiNe/g8CuaUXw+whQawUjWp2u3C3/XVAw8fzV2s+3rtaH30ldjT+QbTy3QXM5 KsJwI8+Powz5XQcyGdKipUc0O2Lr82Yquj9rK+17TpXMjoz86pNtV9zVKHJafciz7/MQ O0fA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=lzdhiobv; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q11si3466297pfs.179.2021.04.17.10.55.02; Sat, 17 Apr 2021 10:55:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=lzdhiobv; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236878AbhDQRzZ (ORCPT + 99 others); Sat, 17 Apr 2021 13:55:25 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:19663 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236760AbhDQRzY (ORCPT ); Sat, 17 Apr 2021 13:55:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618682098; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=//tt+92mj+eYFVIm05nfExvtVOpazpB/GHsyCOcGeeg=; b=lzdhiobvTIatAimp7mQFeuWaOKPVYHwUVUYGN6AarJHMiECClTYoTtKoTyEuDhZOPiaGRRLw jIcYJyxJGD7nPaCFo37Ql6edEPqiL4XfZB0qMnNZyfFxU21GRMPZYoR78Qyfks2mbtGBqV/u 0OjF3lgPzr8IR4usEkag7YKF8bw= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 607b20ebe0e9c9a6b6c81a4a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 17 Apr 2021 17:54:51 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9D342C433D3; Sat, 17 Apr 2021 17:54:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C08B1C433F1; Sat, 17 Apr 2021 17:54:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C08B1C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wilc1000: fix a loop timeout condition From: Kalle Valo In-Reply-To: References: To: Dan Carpenter Cc: Ajay Singh , Claudiu Beznea , David Mosberger-Tang , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210417175451.9D342C433D3@smtp.codeaurora.org> Date: Sat, 17 Apr 2021 17:54:51 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > If the loop fails, the "while(trials--) {" loop will exit with "trials" > set to -1. The test for that expects it to end with "trials" set to 0 > so the warning message will not be printed. > > Fix this by changing from a post-op to a pre-op. This does mean that > we only make 99 attempts instead of 100 but that's okay. > > Fixes: f135a1571a05 ("wilc1000: Support chip sleep over SPI") > Signed-off-by: Dan Carpenter > Acked-by: Ajay Singh Patch applied to wireless-drivers-next.git, thanks. 2f51061edab9 wilc1000: fix a loop timeout condition -- https://patchwork.kernel.org/project/linux-wireless/patch/YFS5gx/gi70zlIaO@mwanda/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches