Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1240158pxb; Sat, 17 Apr 2021 10:55:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlzMs4HGtkvdzWrhybALEiGt6ENaM1M/N5unDgqOKwZBgKzRTnh6YOC7AgLVwJFozts1yG X-Received: by 2002:a17:90a:b00c:: with SMTP id x12mr16145470pjq.216.1618682158371; Sat, 17 Apr 2021 10:55:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618682158; cv=none; d=google.com; s=arc-20160816; b=KljSAwTKCFp3NwJhKRCY1Tz0l7D+nJ2HBgKWb5FSuXI7kHzSz/kS2mNNs7mxp89qU5 x/fgTXat5clPJ2JOt2o/XSRZeTwWvFCrzntUIpuUFU3khBjSvOTBiZl9L2+6SDNGyVIl K2V3P17Zu4jWo9Fyzvhb5tPCDMBklcCHl9ddGY4ZJpfeKAj/bBty8zFgmk9u8ukyeBKE 2VLv3mK323NAjluyK9nLwTq8AsumFVexHz/VdZsCJQ/1r+mhpcoFRnIwWeoNqIDDf+GK bxd6dhcB8ndn86cGIvYSDrzk1R2AFIwN0n+jOref8yD1bT3QpbJrA/fibOnjDlapRLjo Wxiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=6QrwTzf39SIEDg4ZzpC44kNc2ctf71NHN7DHe9aDuy4=; b=xlHU02SlnTWPlvmZYYPMKpWW3e0NRAeFJ4AF9kPxEwpgdn7VmkBeTwKbrPXNxHdiYN kmfj9fW0BoEGN1OWm13LAsNeKns2PkC1Sgw0PBUmvIZu80PR6BIewe3GKXwzLTnMDzOv dMYTCBXGWD/ZBuzHJ+SmDpLhh1A21JJraHeK2wN/0rjeEVQTBHeI5garJfBbWiop3BHi 7N+wtCsqN9WpyBjTNd780TWriyOgs/PkB+OXO480cAFynPNy9k+fIpAj+0MSQCiYMqNl M74/nDfCdKr9ZCBmIAW93usiC0qAbV4nowR7An2NPqxIq4CCQgmtdJfQX+CLoZGU996R X0tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=d4u5srCC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si10646874pls.257.2021.04.17.10.55.45; Sat, 17 Apr 2021 10:55:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=d4u5srCC; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236887AbhDQR4J (ORCPT + 99 others); Sat, 17 Apr 2021 13:56:09 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:30719 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236759AbhDQR4I (ORCPT ); Sat, 17 Apr 2021 13:56:08 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618682142; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=6QrwTzf39SIEDg4ZzpC44kNc2ctf71NHN7DHe9aDuy4=; b=d4u5srCCb751gIg+utz/ZPf+mmgmBD7fdl9LjX0dBvsokC//Lh52X9FBC3IvzJDWVltmWwA+ /Fubj6U7bCRWSe43Arp81YlF4m0Iw1lnIdLvuMMgCNOupc4hLUqtJrB7yL0Yfp+sz1yECJBt BQTf/+7/b3mVNY7j20hOjNL2D6M= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 607b211ca817abd39a2b054e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 17 Apr 2021 17:55:40 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 18F9DC4323A; Sat, 17 Apr 2021 17:55:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 7F2F7C433D3; Sat, 17 Apr 2021 17:55:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7F2F7C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtl8xxxu: Simplify locking of a skb list accesses From: Kalle Valo In-Reply-To: <8bcec6429615aeb498482dc7e1955ce09b456585.1617613700.git.christophe.jaillet@wanadoo.fr> References: <8bcec6429615aeb498482dc7e1955ce09b456585.1617613700.git.christophe.jaillet@wanadoo.fr> To: Christophe JAILLET Cc: Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210417175540.18F9DC4323A@smtp.codeaurora.org> Date: Sat, 17 Apr 2021 17:55:40 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Christophe JAILLET wrote: > The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail() > and __skb_dequeue() calls. > Use the lock provided in the skb itself and call skb_queue_tail() and > skb_dequeue(). These functions already include the correct locking. > > Signed-off-by: Christophe JAILLET Patch applied to wireless-drivers-next.git, thanks. 431eb49e87ed rtl8xxxu: Simplify locking of a skb list accesses -- https://patchwork.kernel.org/project/linux-wireless/patch/8bcec6429615aeb498482dc7e1955ce09b456585.1617613700.git.christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches