Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1243535pxb; Sat, 17 Apr 2021 11:02:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwisXMIjvQ1nwGhXPRjoLxZn3vnVAXb41YudFFOsUKkoEdPqMwm7N2aHsz6ND/0bzlsqilr X-Received: by 2002:a17:907:77d9:: with SMTP id kz25mr14035819ejc.153.1618682572348; Sat, 17 Apr 2021 11:02:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618682572; cv=none; d=google.com; s=arc-20160816; b=yFIfXfswJq1MPqIZ+hHK2FDr63vVlfY+/ZD7qXMjo49R/jk1upfbzYjCJMTgBkQJNr UNk4bl96Rk/bxkbMP3GdsUX9oSEr9d0sh3owP4pcJL9ZyFbHTHYrpd50AwcOBe+JsjC8 XtnNor04NRcBkwGaFKuaeQhNKujTsxsyFbdOOj77tnP4q3gkmbCiXbx5SJxUEL+8s3xV jjPyHG38rCrX7lbrFky51ny3Ryu/wuc5mi2NJeZ4v/r1d5ncQv6o+l6NkAqzfW7MdHhp o/3eIWUHBEYKed90PXVezEdO9aFH6RW2jtG7S73tneK51z9fBUA0xcPF6Xta7OvTK+yg aU7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=oGRlOSXczuP0DJCaBHzbDqORGAinXBLa+Yc9c3vGhJg=; b=L4UdACm8O1vyDyga7mL+EhqSf8gkicuwOz+mrvHanoLQz3OFu3quBJE8x7jb9mb8Pj AXcGocYBvNwrZCkV/RPFDW1HNM0Lzw6RsuyHxot9hlFtcmq2eL13VU49UH22B5rSwR8J REGtZXINEkm8Wl9CCE/plwD/sDRQyebxD9YPT0iZSUHMDTaEAZgb/UlDV0Zw3dPdr8hj Td3gj00fN0BrOjOTIqZYvE6QRXPN/Rt6jRGVQkjcCsdiyGf3RRxVBaySnXa0drGmFun3 1ZqDIkyiTWJvpbgVAP41cgOg0EXw2swSlAuJNpW92QbIhPUWQH5bAC02WSoQ4sV6zSb6 JPpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=FRAEoB15; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i23si4161032edv.235.2021.04.17.11.02.28; Sat, 17 Apr 2021 11:02:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=FRAEoB15; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236948AbhDQSCN (ORCPT + 99 others); Sat, 17 Apr 2021 14:02:13 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:21521 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236759AbhDQSCM (ORCPT ); Sat, 17 Apr 2021 14:02:12 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618682505; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=oGRlOSXczuP0DJCaBHzbDqORGAinXBLa+Yc9c3vGhJg=; b=FRAEoB15KbbLgVaRgmZU2/iu6XdvF/cGI7C35+7GpJ9vzeMZ1N/Zx+5LVal03yoyRYoaxo/I NGx8guKclNbe3LCXKvCQqy93OgIc12b64t/u8YdB2nVhQwppDzepCuGGP9Kl0Ht6O+VQt+Os fig96A9LOHmSTy1esQC2JwiiKZY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 607b2285c39407c327a875d2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 17 Apr 2021 18:01:41 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F29E0C43460; Sat, 17 Apr 2021 18:01:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id BA67CC433F1; Sat, 17 Apr 2021 18:01:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BA67CC433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH net-next 4/5] libertas: avoid -Wempty-body warning From: Kalle Valo In-Reply-To: <20210322104343.948660-4-arnd@kernel.org> References: <20210322104343.948660-4-arnd@kernel.org> To: Arnd Bergmann Cc: netdev@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Arnd Bergmann , Jason Yan , Lubomir Rintel , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210417180140.F29E0C43460@smtp.codeaurora.org> Date: Sat, 17 Apr 2021 18:01:40 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann wrote: > From: Arnd Bergmann > > Building without mesh supports shows a couple of warnings with > 'make W=1': > > drivers/net/wireless/marvell/libertas/main.c: In function 'lbs_start_card': > drivers/net/wireless/marvell/libertas/main.c:1068:37: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 1068 | lbs_start_mesh(priv); > > Change the macros to use the usual "do { } while (0)" instead to shut up > the warnings and make the code a litte more robust. > > Signed-off-by: Arnd Bergmann Patch applied to wireless-drivers-next.git, thanks. 01414f8882f9 libertas: avoid -Wempty-body warning -- https://patchwork.kernel.org/project/linux-wireless/patch/20210322104343.948660-4-arnd@kernel.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches