Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1546065pxb; Sat, 17 Apr 2021 22:56:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYijgDdvepWeoA2a74E5PGAqaOGrhcpdtObvxfWtbVduId+9Gh6S11wFw8H6eKO64me5gq X-Received: by 2002:a17:902:e74f:b029:ea:f2b5:1add with SMTP id p15-20020a170902e74fb02900eaf2b51addmr17233499plf.29.1618725393165; Sat, 17 Apr 2021 22:56:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618725393; cv=none; d=google.com; s=arc-20160816; b=SmeUhabK/oCWBnkzih54JmeCIkslWkOP7IMiAA0tZoxLC3HmkS9oskWf3UsaAse/BM 3LRZHkcukB5wwcP8bEirdcGyuU++1rqXgMefm5VlKZRWcNLoddQ6j6r/zCdX3o9w+dTt tLZkuHiqR9Zy54/QuZCjqLtbG0UOcgUwLFFxJMEPDAaKZzQ1ZqQU8VAXxh7Lcd/v4FeI eSgowuSRVcd/P3xVmgIPckduw07vZG9Zf31y4Wc5L0ui4xIzQtmxAx/ZGDJO8Eyh3sdf hzOlW/UH4k2iyUWTEKRwsdXOpLBkZei2ZyUcFgmW/ZtNsI7/+jSGUFFFjaX1lVp8xZ5G ZMGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=GUuUGywy2mH+60y9PKNoI/P0xG2sd/9arcB7KOwkpPg=; b=ECAzP/NnBH8coaT2MN1BrVtd+EhV8ZdUQku4f4p9iySYEfCfc6cDXDPqJ331+kkM9K O48X3SFt5OlmycApaN+PstXByaQbRGysSBwXENwrnFYPshyNSfr6F0hk76IC5DTBzwlY 9y8S7oPw3hDIxxAuoxqMOJLvTkEXu9ZTi3rWQBaAL86SWkwuGoJAcPL6A1/DJp19S70O 0C4bjumBwUvBEVV0iHqJUIf4xl17KlBOuXUDkBzvHP/gJPvV7vkYBou0KiLIW6bnqodN XFOGgt+5WIV2ylLwki2xmY7o3U0h8tpf/icjGatRh8m2KFGiu8GknjN5aI5cl+ik86eQ VGlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=PO+taF7L; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l17si12175953plc.418.2021.04.17.22.56.04; Sat, 17 Apr 2021 22:56:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=PO+taF7L; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235936AbhDRFy7 (ORCPT + 99 others); Sun, 18 Apr 2021 01:54:59 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:40158 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbhDRFy6 (ORCPT ); Sun, 18 Apr 2021 01:54:58 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618725271; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=GUuUGywy2mH+60y9PKNoI/P0xG2sd/9arcB7KOwkpPg=; b=PO+taF7L7cCf5Zz19SoPOk4FdQpR7iV0IzxqWQjEeKzpjGNXLP4sX68G1zrnRT1GnqMFHHDF t+nOlHqNPj3VOAcvNu2Rbjgd1UmgaGJtuVBWVpERsh+v2hhNGGbUqbVkn5HsIt/sOp3q23Rq 2M4G3/zEO2C/L0Z6qWapxk5JUVg= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 607bc9962cbba88980ac24b2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 18 Apr 2021 05:54:30 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D5B49C4323A; Sun, 18 Apr 2021 05:54:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 571D6C433D3; Sun, 18 Apr 2021 05:54:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 571D6C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] marvell: libertas_tf: fix error return code of if_usb_prog_firmware() From: Kalle Valo In-Reply-To: <20210305033115.6015-1-baijiaju1990@gmail.com> References: <20210305033115.6015-1-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: davem@davemloft.net, kuba@kernel.org, lee.jones@linaro.org, colin.king@canonical.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210418055429.D5B49C4323A@smtp.codeaurora.org> Date: Sun, 18 Apr 2021 05:54:29 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jia-Ju Bai wrote: > When check_fwfile_format() fails, no error return code of > if_usb_prog_firmware() is assigned. > To fix this bug, ret is assigned with -EINVAL as error return code. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210305033115.6015-1-baijiaju1990@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches