Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1546343pxb; Sat, 17 Apr 2021 22:57:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxi5sy+PWKES6qTgIOlwjUzOz+MM7mO3SEh32QUKrJbdGNnp8qwVvUrPy0NE+ZSAq2+CW4B X-Received: by 2002:a63:70e:: with SMTP id 14mr6153527pgh.202.1618725434417; Sat, 17 Apr 2021 22:57:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618725434; cv=none; d=google.com; s=arc-20160816; b=tzYsLRmzf0RSBKr1+BZBosg15e7V1XvcMRyz8N/rki2jPGcaVX8QDTXUYjdAsUF9ij a2Kz8acDSEvdyPIJJ3j0B6TD83EHZLhSXLgfSrON/Pde6cSkprXFaeKWM+RQMRYg59T8 DzgWXLX7joci6ivHTUhqkMWxrTVn/N2rIJ4Vh/RzuY9SiStNb3iCuEbS7bjBD1vey5+B CuDuEbWW7G3zMP2MksDnGWW1AqzSwE4LWLRHCJYFv6n38C4TC/lX/dT0epsTy8Ruj+zP GNSkcBNEgEGUYJiNBpkUAP2tgkuVfitRjvtf9NeA0QJtzjCIokXl9ZTK9ZOlPc0F+0Y6 MAUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=KY17G28Y9iBj64g7cAtJvCZNur5j02GV8ysqTINmatA=; b=DByvg5LUSp3jvIoCwbLT/BinIKBSJ+V2Ht8KjKN0SzkrjcTyD1o8/StLB0MO93doBC DoscumCn4hTBzjuweoL0rKz8odFLrAE/3yzHHWsu8M0FRKPPxStWotSnKlI/vVRLhWgq UAxftt5E8dGJqGqtXK/kputFUhmLiM74U5pjcnG+VvRsnkh6EDuX2ZQdGhqbPPWc3W3o xbECfp6jpqMu8+m72c43Y7SIz5evfcOypJJVUH+3zsMFTZxe/qtoHQb2qcHCaRHV3YVL JY4lIZzSLyFnRYgabrsG2X/jbA/m0QwpKsVnVISxaoXYpnf+JjpCW8a2jLj4SCQ/Uc2H Qxeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=w7T6SZKn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l17si12175953plc.418.2021.04.17.22.57.01; Sat, 17 Apr 2021 22:57:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=w7T6SZKn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236514AbhDRFzv (ORCPT + 99 others); Sun, 18 Apr 2021 01:55:51 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:40739 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbhDRFzt (ORCPT ); Sun, 18 Apr 2021 01:55:49 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618725322; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=KY17G28Y9iBj64g7cAtJvCZNur5j02GV8ysqTINmatA=; b=w7T6SZKnyWogKJnjknQBtKfxz8qWApBKHMIv1ARpNZVWtuasO2O2sitBzSP2xMyMAzpOBAbp F80kHxFarHVJLkG++yH3Wk4VCSZACYd8GVZW79e/Pt+8jIB1twaI0Qp3ez+ZAR8TsnKu7y8m robO9RO2ChYBnpDnt+Uq6nwGhOs= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 607bc9c6f34440a9d41fe912 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 18 Apr 2021 05:55:18 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0A4C0C433D3; Sun, 18 Apr 2021 05:55:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 76406C433F1; Sun, 18 Apr 2021 05:55:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 76406C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ti: wlcore: fix error return code of wl1271_suspend() From: Kalle Valo In-Reply-To: <20210306143600.19676-1-baijiaju1990@gmail.com> References: <20210306143600.19676-1-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210418055518.0A4C0C433D3@smtp.codeaurora.org> Date: Sun, 18 Apr 2021 05:55:18 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jia-Ju Bai wrote: > When wl is NULL, no error return code of wl1271_suspend() is assigned. > To fix this bug, ret is assigned with -EINVAL in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210306143600.19676-1-baijiaju1990@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches