Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1546508pxb; Sat, 17 Apr 2021 22:57:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBf+dEaqhHRIUmiCab+j8bYo9X+DyUsr6Fc8DnWi2FKcnK4ramsoaGgtYj10xTzwwIb0C6 X-Received: by 2002:a63:d242:: with SMTP id t2mr6170486pgi.431.1618725456937; Sat, 17 Apr 2021 22:57:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618725456; cv=none; d=google.com; s=arc-20160816; b=OFwvinGv1Dj0fhNpBZQlngot/ET/AVTMgvGT6Ht6LbPlDiZOzLZSmacnN2oQVdk5u7 ZvpOxXLSZeuKCsJwWtsGEDq8uxgxWt6biSeLyhkBLVQXhQtFuEvrvFMeA8JZSDFqCFYC ohHjMMr6VzUzZ6a18eDyaXeXDkrbf2zOf0S8eT9s2GBQPVyUc5UEU97dS+Bv9UWIP3dx rvYilpVdIBjMf4pIf2h2Ikcrrd5IPPPFrNlIMJmRfzFVP9irnIGyCIXoTiHu7ZLSGw9D yNCHjXC/IQ99ZUdqui34fd4qU0QnHRH7fTW6qyeRfG0WYbkuwhcDqlCMh2zs7Ibr3qRG dYmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=igdUaRyaxUqTqUu8GzWWjHaq3ftiOYE2xM21Khaf0B4=; b=JpbxZbRQEC/TJaNZBQ/HkRDOLT4ZshORMkS2RLXWS0Me90ISZZ8ZB0muvgYi6CLBij jYnBOX4bHwtYyogtM/rz5AAf7uN+1B7FLy/ePv4i1566OtMpbIoFhdRR4nufjo+yDZWi ksyEJjFyzzLKh8n6hpTBofLgXd3QVZ8qvcwDvlZDmk1xk3af7lu3GWMv+nMJq02UMzsr 6zYAp/W4XdBngfyxAVSYtD3NSksbIHbWlzqXGTb7P7bpCLdffbS1Vk19xz2vZkaGLY6s fKxNl+VqsGa0UUwnf12dhfjRAh0Nb/7L8y6w09J4Y7nePlMbLZO/xMUgbpIkh7YmrbVW CdjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=LrSpl104; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l17si12175953plc.418.2021.04.17.22.57.24; Sat, 17 Apr 2021 22:57:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=LrSpl104; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236831AbhDRF40 (ORCPT + 99 others); Sun, 18 Apr 2021 01:56:26 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:54757 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231397AbhDRF40 (ORCPT ); Sun, 18 Apr 2021 01:56:26 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618725358; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=igdUaRyaxUqTqUu8GzWWjHaq3ftiOYE2xM21Khaf0B4=; b=LrSpl104/yVyzoVUSeLx/gU2CNXtdzngroFkgiu+/wx4dP0sVaTJGNdwnsT0x5AaqYwE3H88 u9vVrxTPHqWzRTGDIQAo0NcaYXi4lJi2mQMvn3Nedp4b6Litonbu+Mc+KhdRWgyuzKbPTDUj VsjNHLtyHEqJagiC01Q74C3Nz+g= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 607bc9eca817abd39abd4747 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 18 Apr 2021 05:55:56 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AD55EC4338A; Sun, 18 Apr 2021 05:55:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 39899C433F1; Sun, 18 Apr 2021 05:55:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 39899C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ti: wlcore: fix error return code of wl1271_cmd_build_ps_poll() From: Kalle Valo In-Reply-To: <20210307082906.20950-1-baijiaju1990@gmail.com> References: <20210307082906.20950-1-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: davem@davemloft.net, kuba@kernel.org, lee.jones@linaro.org, colin.king@canonical.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210418055555.AD55EC4338A@smtp.codeaurora.org> Date: Sun, 18 Apr 2021 05:55:55 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jia-Ju Bai wrote: > When ieee80211_pspoll_get() returns NULL to skb, no error return code of > wl1271_cmd_build_ps_poll() is assigned. > To fix this bug, ret is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210307082906.20950-1-baijiaju1990@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches