Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1546730pxb; Sat, 17 Apr 2021 22:58:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2SXnzTjaZ2OH2W3bJQ75ChdgF8KvvfBJZGZ9Efi4a+98Cvjti8rL3vxgtCPk+/I0qWdz5 X-Received: by 2002:a17:90a:6304:: with SMTP id e4mr17390725pjj.63.1618725492961; Sat, 17 Apr 2021 22:58:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618725492; cv=none; d=google.com; s=arc-20160816; b=rZLCTjL5cKep2nUnHp0wR6Mar59/gQ0O8RT6pDkJlGHVpVWAN6p3XW6qaIjnBWh9jg NzW2PcNBo/TBqgeVOmEYXEQ9g2j3PmLqE10HBf2U4LEAlMQl8VmqCmgQ0/frGg5fNyIb aHa9/Op/kNx3W2yyeKGE0F/97BjtEPqpSy3vK1ZL6RVZQNEv+AcLp31BI66GTQWH7E3X 64txxZfA/02v8ln4xVTHez5Gtcqmm4UmN6nhuymnW+QvSKMunx5dcunhXt31ygFTsthI Xtwnun52EE1LH5EItVlTQispee1E1BVb7SfYOK+q/fFjL7UqGRHrMBVY8uLqz9fU4Iiw 4c3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=n1O9903wCMJIihMlxk/UFUq2nl3J4IniVovtVagGMAA=; b=xOKSF0LciChqjkdJKlgrLMCAh4V5Ne5KOAHyAbvrDXhA2xz9CdGkwkv6LJad8WXSla mZ3lmaPOsmCKCJs+0bQi4kWDd2kFJSixLRWeFPVlPweiJy+oDm2mjs+B08rksvzaL83v 5NrAUQ1W/EMAMOMlk6OVERqTlOGVpPjbS4LJNqkb2GVHuk393WAcjBUuZuJRr4ocObuc asTvBTl9YZfyDUIPTUUo0ZwtOWq0mf4oF0QDgWQ4YhY5ALphSItDLBahaFcxmSYMq3wP x6ersn9VTbJE/48gdhA0gYgAO8VvOIXXrXUwlevRnmgaIcAjIfr4JcdAKPER5qsu+nbf 4aiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=dMoCMsIK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c13si13367429pjs.142.2021.04.17.22.58.00; Sat, 17 Apr 2021 22:58:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=dMoCMsIK; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236905AbhDRF4x (ORCPT + 99 others); Sun, 18 Apr 2021 01:56:53 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:19351 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236772AbhDRF4v (ORCPT ); Sun, 18 Apr 2021 01:56:51 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618725384; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=n1O9903wCMJIihMlxk/UFUq2nl3J4IniVovtVagGMAA=; b=dMoCMsIKCq0Yb8F+Kgio+Ucrja9HgaVHCzAqreCgEQ6sWNDSKrllXXm5npK2KTXEwc5IY645 1CAFPs/AVNdfxr20UeHQ51R02qPIZeu8EhcPr2/V6VFtkhQBTDf/Zlnk7JeP9m9fvbP+QNvL BssCWHO4fB/MZ3K2TYupxmgJq7E= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 607bca072cc44d3aeacbe21c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 18 Apr 2021 05:56:23 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 60CCDC433D3; Sun, 18 Apr 2021 05:56:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8C480C433D3; Sun, 18 Apr 2021 05:56:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8C480C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rsi: fix error return code of rsi_load_9116_firmware() From: Kalle Valo In-Reply-To: <20210307083445.21322-1-baijiaju1990@gmail.com> References: <20210307083445.21322-1-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: amitkarwar@gmail.com, siva8118@gmail.com, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210418055623.60CCDC433D3@smtp.codeaurora.org> Date: Sun, 18 Apr 2021 05:56:23 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jia-Ju Bai wrote: > When kmemdup() returns NULL to ta_firmware, no error return code of > rsi_load_9116_firmware() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot > Signed-off-by: Jia-Ju Bai Someone needs to review this. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210307083445.21322-1-baijiaju1990@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches