Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1556920pxb; Sat, 17 Apr 2021 23:17:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+ZmQUkO22/SewrxhYAWwzGQM/AN7If277Lbt1avs9sErzzPTNLGxxwfYBCP6EXcoGKvqB X-Received: by 2002:a05:6402:5189:: with SMTP id q9mr18727337edd.168.1618726660807; Sat, 17 Apr 2021 23:17:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618726660; cv=none; d=google.com; s=arc-20160816; b=MSV/tAYNuYhlnzaylkNbX2SvlpOAEKmJi+u4lTUXF5h0UPfIgQYYZ2sHgM8Ytr9SrF i2O1VtHwnmkjIzMPWKGmaUkdSBaI9xsv9HKtX9XDox3HI1OE0W2g9Pit00SZ8XmGZF5h PfUQ6ZH28kBdfXcnSi10P94pTsvmsBbD3ydyFuN8VcYOEqkdyV2BpRAPbKbUowN1CpEA KHSKwChKyAvKX9lT6kaiit5aKJHPMiw3TJR6BRg/IxdGJGgO8/JJz3Z65gNmu4A0KQft lOOLglga7Rpz5EJQWGzQeT5vY2RMqafdP7yCuIw2LogNAHjGUmTSJ7HgwVO3aX2yNKSA rPeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=HzA+cNbw61dWFMzcRtSYDf5FMk35E+JaLg7OiVxSUSY=; b=N/ODXdqMrSBLLmrwNBS3ENU7qFAZ1iaCCY+G5t4tyAe7mqJpXJNQq/1nRl84t8kEb+ Ctz4cHJxUGpxb3LWmZN37W8oxk1xIN6mvhKjnBAIYLnWzqduAxSXLzA5FSqLBzakyZSU Bqw34QIwmStDX3rxQznCDhSTyqGOtfNlbGVH9O1QYrgie/YlHaQzNsLWAV0MUsBvHMAA F9TyDki3DScYu+RuYm7WbEwp7KEeNzcV2sXplDHV56BnNMj2ib0SD2I8c4tKCxv4/CkT l86uD/1Q5rGi0SsmJ5fzkQyYoHRn/1zEuMmmq+0t1oFr+QrlNJ6xSZH2Jr7GUgIiIFyq aG3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=KhdSNfgn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gg20si7317260ejc.614.2021.04.17.23.17.18; Sat, 17 Apr 2021 23:17:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=KhdSNfgn; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236857AbhDRGPY (ORCPT + 99 others); Sun, 18 Apr 2021 02:15:24 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:53893 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235958AbhDRGPX (ORCPT ); Sun, 18 Apr 2021 02:15:23 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618726495; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=HzA+cNbw61dWFMzcRtSYDf5FMk35E+JaLg7OiVxSUSY=; b=KhdSNfgn6gGFJROpSgERwJdYtMxAFPjXAYuroTK9pacRtJHB03d67yY84F6q2yi8empQpAH4 BB3ivX1VU92jEGas17rJP1HvuYfxdoyFQUDTPnx+WVFbElT23m4IyeZwo1S95R/cwYO0/0UA CuRbpcy7dKmCLMubfGumOwACfFc= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 607bce592cbba88980b3d6f7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 18 Apr 2021 06:14:49 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E95B9C4338A; Sun, 18 Apr 2021 06:14:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0A061C433F1; Sun, 18 Apr 2021 06:14:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0A061C433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] hostap: Fix memleak in prism2_config From: Kalle Valo In-Reply-To: <20210329085246.24586-1-dinghao.liu@zju.edu.cn> References: <20210329085246.24586-1-dinghao.liu@zju.edu.cn> To: Dinghao Liu Cc: dinghao.liu@zju.edu.cn, kjlu@umn.edu, Jouni Malinen , "David S. Miller" , Jakub Kicinski , Leon Romanovsky , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210418061448.E95B9C4338A@smtp.codeaurora.org> Date: Sun, 18 Apr 2021 06:14:48 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dinghao Liu wrote: > When prism2_hw_config() fails, we just return an error code > without any resource release, which may lead to memleak. > > Signed-off-by: Dinghao Liu Nobody reviewed this, so dropping the patch. Patch set to Changes Requested. -- https://patchwork.kernel.org/project/linux-wireless/patch/20210329085246.24586-1-dinghao.liu@zju.edu.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches