Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1564964pxb; Sat, 17 Apr 2021 23:34:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQM2ksYVcJROfHDpjzumNNfvOTJD76dxymIsoBu/jLad9ZZRWl/L0PNO73l8UXgJ19hbp6 X-Received: by 2002:a17:906:6bcb:: with SMTP id t11mr15397359ejs.395.1618727672677; Sat, 17 Apr 2021 23:34:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618727672; cv=none; d=google.com; s=arc-20160816; b=EAy/ZUV5qT4BXiUqNl2rcQm6HxJKjHgh8URVA6xIAF9oO6LKOsPZrZ0W7Ey7mvXxyq TmBA5HrbveIYKGa6RZ4gWxbY8KbrMYgKqAGtdSws96LTGhNgPes2tg8OTBNaDbd2mYax 4F9/vVyn4iW/xWbYleD0U2JH+yh5Ys11s+kr0nMrjVWB9wiDXgJF/ZQnSx3p+NiUWvQN MAFKhXFg2azAIwcgsa14ofCr/SJGzV6tGvyHw08v7bjePcdHoccS74bkNpi1kkA1FrSa TFyW2uSyQwM9QuyBe0CN1nRylScNl60WKpEkXRseOs0ZxWyAoms2ynRIfKwEo7b5lgv1 R/3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dmarc-filter:sender:dkim-signature; bh=Vid4DEVRWQ6zvrf5fFbXUGrzD4z18nv5hzKHHNc29uM=; b=oXK6eyzGwbHD7w0l9L8jbHnPIuxq598JnqP8TaqHMogVICuhyE1sKrvP7rweRttQUO W+8F0aW7NlY3ERJmfVU3i7YIsMxyQ7yTb6lnBKIg4PFUtGGyaD/6Xwqo7J7zqmCIxuff KvWP67B/bZW1Ov5jQgD3Vl2WXMl57hCbDUiU1VQnT65o10TAaQzSlaaxYSC3a+fJ51qc XnjsG90le1Ihg5OEittN3xrv11ejcF9YwEGWGoVauHZ6N0XqRpu1MVq/b+6tokIWdKjC Q2WvcicsTvd/XBNSPdippCGfhunEunWRn2kW4kNIUcx1332uZHeMquM+yI/HeunDDZCg uSsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=TRYlNAFN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b20si8944043eja.632.2021.04.17.23.34.10; Sat, 17 Apr 2021 23:34:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=TRYlNAFN; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236972AbhDRGcv (ORCPT + 99 others); Sun, 18 Apr 2021 02:32:51 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:15324 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230339AbhDRGcv (ORCPT ); Sun, 18 Apr 2021 02:32:51 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1618727543; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=Vid4DEVRWQ6zvrf5fFbXUGrzD4z18nv5hzKHHNc29uM=; b=TRYlNAFNzqzd66jBk3JebENZoAC98Z4vzc+UzUo5TxnCnJKtNHCBIdP/m7EvqThFwSCJa0GB ogzY4leeOU3C1Y+2IJnv2udrOsuhma3IblilnyS5/TyIzK6gucQeyykB2xWorjtkeLug3aGm r7tvxt9nk2YawRBVhSkPfuSSQlc= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 607bd277a817abd39ad32ef6 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 18 Apr 2021 06:32:23 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 710BBC43217; Sun, 18 Apr 2021 06:32:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, MISSING_DATE,MISSING_MID,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 64A6EC433F1; Sun, 18 Apr 2021 06:32:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 64A6EC433F1 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rsi: Use resume_noirq for SDIO From: Kalle Valo In-Reply-To: <20210327235932.175896-1-marex@denx.de> References: <20210327235932.175896-1-marex@denx.de> To: Marek Vasut Cc: linux-wireless@vger.kernel.org, Marek Vasut , Amitkumar Karwar , Angus Ainslie , "David S . Miller" , Jakub Kicinski , Karun Eagalapati , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org, stable@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210418063222.710BBC43217@smtp.codeaurora.org> Date: Sun, 18 Apr 2021 06:32:22 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Marek Vasut wrote: > The rsi_resume() does access the bus to enable interrupts on the RSI > SDIO WiFi card, however when calling sdio_claim_host() in the resume > path, it is possible the bus is already claimed and sdio_claim_host() > spins indefinitelly. Enable the SDIO card interrupts in resume_noirq > instead to prevent anything else from claiming the SDIO bus first. > > Fixes: 20db07332736 ("rsi: sdio suspend and resume support") > Signed-off-by: Marek Vasut > Cc: Amitkumar Karwar > Cc: Angus Ainslie > Cc: David S. Miller > Cc: Jakub Kicinski > Cc: Kalle Valo > Cc: Karun Eagalapati > Cc: Martin Kepplinger > Cc: Sebastian Krzyszkowiak > Cc: Siva Rebbagondla > Cc: netdev@vger.kernel.org > Cc: stable@vger.kernel.org Patch applied to wireless-drivers-next.git, thanks. c434e5e48dc4 rsi: Use resume_noirq for SDIO -- https://patchwork.kernel.org/project/linux-wireless/patch/20210327235932.175896-1-marex@denx.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches