Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1874862pxb; Sun, 18 Apr 2021 09:46:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZq1icys7VBH+JMCFXfKCV+MTyPEU2x8Zu4CB6SX1vv5u8VFKrXM6J8hpqEHPQswZHpitn X-Received: by 2002:a17:902:6b43:b029:e6:3d73:e9fb with SMTP id g3-20020a1709026b43b02900e63d73e9fbmr19347770plt.37.1618764407320; Sun, 18 Apr 2021 09:46:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618764407; cv=none; d=google.com; s=arc-20160816; b=siQfXlCH0mioWXFPaMOdwU3ZKnXqpxA4Zd5F4XfAan/6enF8rwWHACAwOKaHDYsI3l VXWLRpUtiAktU+Hxf9ezPqr4YkNo0Wp+kNnw4dgI2y2TUGk7I7iUt9j2rWChoPpWWqux Y+MMqb9zkwT13N/Vlr0u4JL3dSrTlS/Eg6Zm+tUx4ffX1EHWgk7BGNZWMHuOjZ3IOo8J Htzmt0cn8C8CCsZZS37kHMuSbvCzkjCk+5IXXWfNNX+7gAM5F+0l0Jt1xklORh269I+t alP7GMrV/Q5EYZe0UFbvELap6Law9M2QJQ90lli3fiQ29ufFS29Kl0Z/MfDPRv3yU/QM 4y6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BmQrDMuE8PhKKhbGVBg8zrYJ/t5Ko3bXkqe98gguUyo=; b=gWg3X+XoPo49Ddva+teEq8+Wx+n1ohL7t1SO4AR0A3zMZ7XM8DNfscbaaPXASf1fhW zRnfX+rZp3vMAkByliXPBn4OEHTtOhh5mad0qW7Zn3QE8W2hqCCWt6Xr7WvW38nS7TW4 S8/FR4VuBAr7LcPHohN1EJBZEni40zSNgjzwzXEypyy15+SjdJ/bApvc3tX1Hux6cpzD C+D6XJNGhvQ5/gRXkt5n3WIC6AoRuxXNmaD2kLLCfEnl0uLsoxISbQpzQov8JrjmsE/E Fog4caTFvdQ8sSNKqSKy+RJZAXXEqdRsJlC/iwyBuNzKxL2wtGUmajSZe7pIjY+lNdXn 6rEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PFAjWJi2; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si14098529plo.239.2021.04.18.09.46.35; Sun, 18 Apr 2021 09:46:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PFAjWJi2; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234846AbhDRQqn (ORCPT + 99 others); Sun, 18 Apr 2021 12:46:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:49934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232212AbhDRQqm (ORCPT ); Sun, 18 Apr 2021 12:46:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8CCD761359; Sun, 18 Apr 2021 16:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618764374; bh=Qcyjit270av8s5rkw1lAptBR1FzoPr89sm1FbOGdEZc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PFAjWJi24YKxW9eep46oZYAKtiesEfN/ITqORsA+RdCxK/37th8EB1osAoXjSezQs nYj921GRXdt9xfzGFpSNby81/9+aZpv9oWijPf4AwvWHEm8sMwDnSaoC7DKyJMTw6j nUX3thO+7Vm6fDw9226DHWhEEUtjxJha0k/GususjCdI/oVJcX7aP0ENsaLKbPBR8W sQOhX9dcZ2qLic5I+P/+KdAy0tDxACz0Kk6nblW/nHEZvdgjHwbiaDG6isBcoy+iHP EmvzUgClrCcbEBJg8q3npG+h6ZsgV9tqF93zp0L3OzMWp4hIEa+ottLMBS7voagbF/ 5QPnv/JT4IHFg== From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, sean.wang@mediatek.com Subject: [PATCH 14/19] mt76: mt7615: rely on pm refcounting in mt7615_led_set_config Date: Sun, 18 Apr 2021 18:45:40 +0200 Message-Id: <8ca5f4f25fbf630bc6ab23852d2f76b710c47c21.1618763001.git.lorenzo@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Rely on mt76_connac_pm_ref/mt76_connac_pm_unref utility routines in mt7615_led_set_config Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c b/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c index 49540b00519d..736d19699a03 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c @@ -82,7 +82,7 @@ mt7615_led_set_config(struct led_classdev *led_cdev, mt76 = container_of(led_cdev, struct mt76_dev, led_cdev); dev = container_of(mt76, struct mt7615_dev, mt76); - if (test_bit(MT76_STATE_PM, &mt76->phy.state)) + if (!mt76_connac_pm_ref(&dev->mphy, &dev->pm)) return; val = FIELD_PREP(MT_LED_STATUS_DURATION, 0xffff) | @@ -100,6 +100,8 @@ mt7615_led_set_config(struct led_classdev *led_cdev, val |= MT_LED_CTRL_POLARITY(mt76->led_pin); addr = mt7615_reg_map(dev, MT_LED_CTRL); mt76_wr(dev, addr, val); + + mt76_connac_pm_unref(&dev->pm); } static int -- 2.30.2