Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1874918pxb; Sun, 18 Apr 2021 09:46:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqtMMrRpoKBiyKQM91bGgKh8z6Ert5Zart3/xVR3MCy+NSdpIoEcDwDAVaxl7Vp/6sMk3d X-Received: by 2002:a63:2314:: with SMTP id j20mr8057889pgj.409.1618764413995; Sun, 18 Apr 2021 09:46:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618764413; cv=none; d=google.com; s=arc-20160816; b=OqzA5/jgKKMsqxGVnWuRb8suZ1HCnq/n+o7HX8C9xhqMA8Vb+0OoahNUwW+NsX695O 9gOpOr66sq5pW9B2yfXgrxE/be8KSvYuhfxxpsOAWWgtIgj4W/YZE5g0a1FU0VRe/GRL YNad189e6a0ASzsBMUTR9nOxufUnzI3KcxruaGT3NAWM+UVbxCHRXrxaChq30Vx5d8vr YQH8zX0SHywlPm5b4g7AwsjNISSVJAuE4TUIsVGeYP2jxx5t7tI3oMkBNanel2b6TAo/ RjfR5scabXPM9VRU4xkbnYMg/voZB9n93vY75uU9myv6tU4YwdVJeapzCDPzzNsxjaVc +Fug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1Ca4E1lm8QbRqxHVqxaGUMrDz1zw8kPg9XSYP2xbLbk=; b=zrAfsRy/h0mLr6QwfYMLqst9rWitwVic5yzNnnSVjfXUvVMekEFennHjMs01NphvJu 4dU4X2dPol9W91nAoNGElG0Cd3et9kTCnGWXis07n+bMjnm49Q495bXSnxy24ynS29r7 x7OtkrwK+jpoHdPHVb/S5DGJS/6jGiWG38LeVCvHT2QO/VaaQpK6be1sxiQ78j/dEkdf Siaiye+FI0g4nmi0jM/FDoNYA6UYV/ZxTKTjj1Q6hGOojDlXnGpyFMmXDa0/wU413Wxz 5fm8K2NV7V/ZRbCnfDdAmvuMJBMCph069YgQA0jbbP8acXD0k1y05Rj7CxoGbmCRXn6K UZcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RCy5BtJb; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 29si5482974pgv.136.2021.04.18.09.46.41; Sun, 18 Apr 2021 09:46:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RCy5BtJb; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235404AbhDRQqp (ORCPT + 99 others); Sun, 18 Apr 2021 12:46:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:49982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232291AbhDRQqp (ORCPT ); Sun, 18 Apr 2021 12:46:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 37E996101E; Sun, 18 Apr 2021 16:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618764377; bh=niXP5WXX4SN7ofupoo66EXBu0NvWD0d7lxl9KQfiIeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RCy5BtJbcg0YugvdlD1h9nE8cC8aOIU4RLFhLyP/PIbM+SgFZZOQ+Wf+YKEMvaouT GVSFWerWFeDjYgbga22GZG47/dAQurTOf16UaVoB14D8mUVT0c9nXeoFUQLx16Jj44 x9VgoPWL6l11KeAY5PU6uE/kxvyMRUZIdkyVWrqjZ2CEfKe7KjGAmpsRJEQ1E6ZzM5 KV89jRhPThY/oSMESLWQ+rKyRsnl0sJme9rJDABUiGqOgXufCrbdLskJb/DX4RLfUM /UYYR/W0UNuQLgRl6dE5WaWWrm3qPyurGVNWFY+M3foCmNEWrd3pVGRc8QEu9vrwE2 uxG/S2WyNvMOA== From: Lorenzo Bianconi To: nbd@nbd.name Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, sean.wang@mediatek.com Subject: [PATCH 16/19] mt76: connac: use waitqueue for runtime-pm Date: Sun, 18 Apr 2021 18:45:42 +0200 Message-Id: <3a23a827d4ed990bb89bdfa988d0c3c072ce06ac.1618763001.git.lorenzo@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Simplify the code using a wait_queue_head_t instead of a completion to wait the chip is fully awake in mt76_connac_pm_wake routine Signed-off-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7615/init.c | 2 +- drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 2 +- drivers/net/wireless/mediatek/mt76/mt76_connac.h | 2 +- drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c | 8 ++++---- drivers/net/wireless/mediatek/mt76/mt7921/init.c | 2 +- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c index 3ef6bcdf38c4..894b2588e075 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c @@ -508,7 +508,7 @@ void mt7615_init_device(struct mt7615_dev *dev) INIT_WORK(&dev->pm.wake_work, mt7615_pm_wake_work); spin_lock_init(&dev->pm.wake.lock); mutex_init(&dev->pm.mutex); - init_completion(&dev->pm.wake_cmpl); + init_waitqueue_head(&dev->pm.wait); spin_lock_init(&dev->pm.txq_lock); set_bit(MT76_STATE_PM, &dev->mphy.state); INIT_DELAYED_WORK(&dev->mphy.mac_work, mt7615_mac_work); diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c index adbc726149a9..747bf90f9d8a 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c @@ -1919,7 +1919,7 @@ void mt7615_pm_wake_work(struct work_struct *work) } ieee80211_wake_queues(mphy->hw); - complete_all(&dev->pm.wake_cmpl); + wake_up(&dev->pm.wait); } void mt7615_pm_power_save_work(struct work_struct *work) diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac.h b/drivers/net/wireless/mediatek/mt76/mt76_connac.h index 116d800c9f9d..e3937f6d3640 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76_connac.h +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac.h @@ -53,7 +53,7 @@ struct mt76_connac_pm { } tx_q[IEEE80211_NUM_ACS]; struct work_struct wake_work; - struct completion wake_cmpl; + wait_queue_head_t wait; struct { spinlock_t lock; diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c index a263921d9f42..66f1667481e6 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c @@ -17,10 +17,10 @@ int mt76_connac_pm_wake(struct mt76_phy *phy, struct mt76_connac_pm *pm) if (!test_bit(MT76_STATE_PM, &phy->state)) return 0; - if (queue_work(dev->wq, &pm->wake_work)) - reinit_completion(&pm->wake_cmpl); - - if (!wait_for_completion_timeout(&pm->wake_cmpl, 3 * HZ)) { + queue_work(dev->wq, &pm->wake_work); + if (!wait_event_timeout(pm->wait, + !test_bit(MT76_STATE_PM, &phy->state), + 3 * HZ)) { ieee80211_wake_queues(phy->hw); return -ETIMEDOUT; } diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c index ce0e231ab772..2d8dba000d0b 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c @@ -225,7 +225,7 @@ int mt7921_register_device(struct mt7921_dev *dev) INIT_WORK(&dev->pm.wake_work, mt7921_pm_wake_work); spin_lock_init(&dev->pm.wake.lock); mutex_init(&dev->pm.mutex); - init_completion(&dev->pm.wake_cmpl); + init_waitqueue_head(&dev->pm.wait); spin_lock_init(&dev->pm.txq_lock); set_bit(MT76_STATE_PM, &dev->mphy.state); INIT_LIST_HEAD(&dev->phy.stats_list); diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c index 90ede75cfba8..7b5323181fac 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -1530,7 +1530,7 @@ void mt7921_pm_wake_work(struct work_struct *work) } ieee80211_wake_queues(mphy->hw); - complete_all(&dev->pm.wake_cmpl); + wake_up(&dev->pm.wait); } void mt7921_pm_power_save_work(struct work_struct *work) -- 2.30.2